[MDEV-29481] mariadb-upgrade prints confusing statement Created: 2022-09-07  Updated: 2023-05-18  Resolved: 2022-10-22

Status: Closed
Project: MariaDB Server
Component/s: Data Definition - Alter Table, Storage Engine - InnoDB, Upgrades
Affects Version/s: 10.4.26, 10.5.17, 10.6.9, 10.7.5, 10.8.4, 10.9.2, 10.10.1
Fix Version/s: 10.4.27, 10.5.18, 10.6.11, 10.7.7, 10.8.6, 10.9.4, 10.10.2, 10.11.1

Type: Bug Priority: Blocker
Reporter: Oli Sennhauser Assignee: Alexander Barkov
Resolution: Fixed Votes: 1
Labels: regression-10.4

Issue Links:
Blocks
blocks MDEV-28822 Table from older version requires tab... Closed
is blocked by MDEV-29672 Add MTR tests covering key and key se... Closed
Problem/Incident
is caused by MDEV-20704 An index on a double column erroneous... Closed
is caused by MDEV-28727 ALTER TABLE ALGORITHM=NOCOPY does not... Closed
Relates
relates to MDEV-28822 Table from older version requires tab... Closed
relates to MDEV-29495 Generalize can_convert_xxx() hook eng... Closed

 Description   

When running mariadb-upgrade it provides confusing statements:

schema1.table1
error : Table rebuild required. Please do "ALTER TABLE `table1` FORCE" or dump/reload to fix it!
schema1.table2 OK
schema1.table3
error : Table rebuild required. Please do "ALTER TABLE `table3` FORCE" or dump/reload to fix it!
schema1.table4 OK
...
`schema1`.`table1` FIXED
`schema1`.`table4` FIXED

At the end of the upgrade mariadb-upgrade does the ALTER TABLE FORCE itself. So user does not need to do it.
So it would be more meaningful to print a message like "Table rebuild required. I do it further down..."

Customer was confused (an I was as well when reading the first time).

Would be a good task for a simple community contribution if it will be decided to be implemented...

 Comments   
Comment by Marko Mäkelä [ 2022-09-07 ]

Thank you for the report. I think that we simply need a better fix of MDEV-28727, to actually fix what was requested.

Demanding a table rebuild when only some metadata (.frm file contents) is in an old format feels excessive to me.

Comment by Alexander Barkov [ 2022-10-03 ]

Hello serg. Can you please review patches in this branch:

https://github.com/mariadb/server/tree/bb-10.4-bar-MDEV-29481

  • The first patch reverts MDEV-28727
  • The second patch fixes the problem with DOUBLE in a new way.

Thanks.

Comment by Alexander Barkov [ 2022-10-21 ]

Hello serg. Can you please review a new version of patches in this branch:

https://github.com/MariaDB/server/commits/bb-10.4-bar-MDEV-29481

Generated at Thu Feb 08 10:08:56 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.