Details
Critical Description
The --help output of mariabackup still refers to the XtraBackup innobackupex tool in several places. As far as I can tell all these references were originally just "this tool" references, so we should replace them with references to mariabackup
I know that we also have a mariabackup --innobackupex backwards compatibility mode, but none of the options referencing innobackupex in their help output seem to be specific to that mode, they all seem to be general options.
Attachments
Issue Links
- causes
-
DOCSCOLLAB-251 Loading...
Activity
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 10.5 [ 23123 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.7 [ 24805 ] | |
| Fix Version/s | 10.8 [ 26121 ] | |
| Fix Version/s | 10.9 [ 26905 ] |
| Assignee | Sergei Golubchik [ serg ] |
| Assignee | Sergei Golubchik [ serg ] | Alexander Barkov [ bar ] |
| Component/s | Backup [ 13902 ] |
| Priority | Major [ 3 ] | Critical [ 2 ] |
| Attachment | mdev-29244.patch [ 66040 ] |
It seems the canonical name of the tool is mariadb-backup,
while mariabackup is only a symlink to it.
Shouldn't we use mariadb-backup in the help putput?
| Status | Open [ 1 ] | In Progress [ 3 ] |
Hello serg,
Can you please review this patch:
https://github.com/MariaDB/server/commit/4cd4bb8024a66eb4d006e4d5e564e459900f0ae0
Thanks!
| Assignee | Alexander Barkov [ bar ] | Sergei Golubchik [ serg ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
right, I thought the symlink direction swap had only happened in 10.6, but it was actually in 10.5.
So mariadb-backup should be used instead of mariabackup. Or whatever the basename of $argv[0] is, maybe?
PS: there is another hard coded reference to the old name in help output:
--mysqld-args All arguments that follow this argument are considered as
|
server options, and if some of them are not supported by
|
mariabackup, they will be ignored.
|
| Assignee | Sergei Golubchik [ serg ] | Alexander Barkov [ bar ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Status | Stalled [ 10000 ] | In Progress [ 3 ] |
| issue.field.resolutiondate | 2023-01-31 07:50:22.0 | 2023-01-31 07:50:22.884 |
| Fix Version/s | 10.5.19 [ 28511 ] | |
| Fix Version/s | 10.6.12 [ 28513 ] | |
| Fix Version/s | 10.7.8 [ 28515 ] | |
| Fix Version/s | 10.8.7 [ 28517 ] | |
| Fix Version/s | 10.9.5 [ 28519 ] | |
| Fix Version/s | 10.10.3 [ 28521 ] | |
| Fix Version/s | 10.11.2 [ 28523 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.7 [ 24805 ] | |
| Fix Version/s | 10.8 [ 26121 ] | |
| Fix Version/s | 10.9 [ 26905 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Fix Version/s | 10.5.20 [ 28512 ] | |
| Fix Version/s | 10.6.13 [ 28514 ] | |
| Fix Version/s | 10.8.8 [ 28518 ] | |
| Fix Version/s | 10.9.6 [ 28520 ] | |
| Fix Version/s | 10.10.4 [ 28522 ] | |
| Fix Version/s | 10.5.19 [ 28511 ] | |
| Fix Version/s | 10.6.12 [ 28513 ] | |
| Fix Version/s | 10.7.8 [ 28515 ] | |
| Fix Version/s | 10.8.7 [ 28517 ] | |
| Fix Version/s | 10.9.5 [ 28519 ] | |
| Fix Version/s | 10.10.3 [ 28521 ] |
| Fix Version/s | 10.11.3 [ 28524 ] | |
| Fix Version/s | 10.11.2 [ 28523 ] |
| Remote Link | This issue links to "DOCSCOLLAB-251 (Jira)" [ 34920 ] |
| Zendesk Related Tickets | 201796 | |
| Zendesk active tickets | 201796 |
Added a proposed patch against 10.5 branch. Added it here instead of making it a pull request due to local github issues ....