Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29244

mariabackup --help output still referst to innobackupex

Details

    Description

      The --help output of mariabackup still refers to the XtraBackup innobackupex tool in several places. As far as I can tell all these references were originally just "this tool" references, so we should replace them with references to mariabackup

      I know that we also have a mariabackup --innobackupex backwards compatibility mode, but none of the options referencing innobackupex in their help output seem to be specific to that mode, they all seem to be general options.

      Attachments

        Issue Links

          causes

          DOCSCOLLAB-251 Failed to load

          Activity

            Ascending order - Click to sort in descending order
            hholzgra Hartmut Holzgraefe added a comment -

            Added a proposed patch against 10.5 branch. Added it here instead of making it a pull request due to local github issues ....

            hholzgra Hartmut Holzgraefe added a comment - Added a proposed patch against 10.5 branch. Added it here instead of making it a pull request due to local github issues ....
            bar Alexander Barkov added a comment -

            hholzgra,

            It seems the canonical name of the tool is mariadb-backup,
            while mariabackup is only a symlink to it.

            Shouldn't we use mariadb-backup in the help putput?

            bar Alexander Barkov added a comment - hholzgra , It seems the canonical name of the tool is mariadb-backup , while mariabackup is only a symlink to it. Shouldn't we use mariadb-backup in the help putput?
            bar Alexander Barkov added a comment -

            Hello serg,

            Can you please review this patch:
            https://github.com/MariaDB/server/commit/4cd4bb8024a66eb4d006e4d5e564e459900f0ae0
            Thanks!

            bar Alexander Barkov added a comment - Hello serg , Can you please review this patch: https://github.com/MariaDB/server/commit/4cd4bb8024a66eb4d006e4d5e564e459900f0ae0 Thanks!
            hholzgra Hartmut Holzgraefe added a comment -

            right, I thought the symlink direction swap had only happened in 10.6, but it was actually in 10.5.
            So mariadb-backup should be used instead of mariabackup. Or whatever the basename of $argv[0] is, maybe?

            PS: there is another hard coded reference to the old name in help output:

              --mysqld-args       All arguments that follow this argument are considered as
            		 
                                  server options, and if some of them are not supported by
            		 
                                  mariabackup, they will be ignored.

            hholzgra Hartmut Holzgraefe added a comment - right, I thought the symlink direction swap had only happened in 10.6, but it was actually in 10.5. So mariadb-backup should be used instead of mariabackup . Or whatever the basename of $argv [0] is, maybe? PS: there is another hard coded reference to the old name in help output: --mysqld-args All arguments that follow this argument are considered as server options, and if some of them are not supported by mariabackup, they will be ignored.
            serg Sergei Golubchik added a comment -

            ok to push

            serg Sergei Golubchik added a comment - ok to push
            bar Alexander Barkov added a comment -

            Rebasing, pushing.

            bar Alexander Barkov added a comment - Rebasing, pushing.

            People

              bar Alexander Barkov
              hholzgra Hartmut Holzgraefe
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.