[MDEV-29244] mariabackup --help output still referst to innobackupex Created: 2022-08-04  Updated: 2023-02-16  Resolved: 2023-01-31

Status: Closed
Project: MariaDB Server
Component/s: Backup
Affects Version/s: 10.5, 10.6, 10.7, 10.8, 10.9
Fix Version/s: 10.11.3, 10.5.20, 10.6.13, 10.8.8, 10.9.6, 10.10.4

Type: Bug Priority: Critical
Reporter: Hartmut Holzgraefe Assignee: Alexander Barkov
Resolution: Fixed Votes: 2
Labels: None

Attachments: File mdev-29244.patch    

 Description   

The --help output of mariabackup still refers to the XtraBackup innobackupex tool in several places. As far as I can tell all these references were originally just "this tool" references, so we should replace them with references to mariabackup

I know that we also have a mariabackup --innobackupex backwards compatibility mode, but none of the options referencing innobackupex in their help output seem to be specific to that mode, they all seem to be general options.

 Comments   
Comment by Hartmut Holzgraefe [ 2022-10-25 ]

Added a proposed patch against 10.5 branch. Added it here instead of making it a pull request due to local github issues ....

Comment by Alexander Barkov [ 2022-11-14 ]

hholzgra,

It seems the canonical name of the tool is mariadb-backup,
while mariabackup is only a symlink to it.

Shouldn't we use mariadb-backup in the help putput?

Comment by Alexander Barkov [ 2022-11-14 ]

Hello serg,

Can you please review this patch:
https://github.com/MariaDB/server/commit/4cd4bb8024a66eb4d006e4d5e564e459900f0ae0
Thanks!

Comment by Hartmut Holzgraefe [ 2022-11-16 ]

right, I thought the symlink direction swap had only happened in 10.6, but it was actually in 10.5.
So mariadb-backup should be used instead of mariabackup. Or whatever the basename of $argv[0] is, maybe?

PS: there is another hard coded reference to the old name in help output:

  --mysqld-args       All arguments that follow this argument are considered as
 
                      server options, and if some of them are not supported by
 
                      mariabackup, they will be ignored.

Comment by Sergei Golubchik [ 2023-01-06 ]

ok to push

Comment by Alexander Barkov [ 2023-01-31 ]

Rebasing, pushing.

Generated at Thu Feb 08 10:07:00 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.