Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28446

mariabackup prepare fails for incrementals if a new schema is created after full backup is taken

Details

    Description

      If a new schema with at least one table is created after a full backup is taken, but before the incremental is taken, the backup cannot be restored because incremental prepare fails.

      mariabackup prepare fails with : Error on rename ..... (errno: 20 "Not a directory" )

      The issue seems to be that mariabackup prepare expects the folder for the new schema to be already there, but it isn't because the schema is created after the full is taken, so can't be found in the full backup.

      This is critical as it breaks backup restores in presence of incrementals when the above condition is met (which is all but rare).

      How to repeat:

      1. take a full backup
      2. create a new schema and table
      3. take an incremental backup
      4. restore the full backup and then the incremental backup; prepare will crash

      Attachments

        Issue Links

          Activity

            rpizzi Rick Pizzi (Inactive) created issue -
            rpizzi Rick Pizzi (Inactive) made changes -
            Field Original Value New Value
            Description If a new schema with at least one table is created after a full backup is taken, but before the incremental is taken, the backup cannot be restored because incremental prepare fails.

            mariabackup prepare fails with : Error on rename ..... (errno: 20 "Not a directory" )

            The issue seems to be that mariabackup prepare expects the folder for the new schema to be already there, but it isn't because the schema is created after the full is taken, so can't be found in the full backup.

            This is critical as it breaks backup restores in presence of incrementals when the above condition is met (which is all but rare).

            How to repeat:

            1. take a full backup
            2. create a new schema and table
            3. take an incremental backup
            4. restore the full backup and then the incremental backup; prepare will crash




            cannot rename table: "errno: 20 "Not a directory" on the schema and table created after the full.

            If a new schema with at least one table is created after a full backup is taken, but before the incremental is taken, the backup cannot be restored because incremental prepare fails.

            mariabackup prepare fails with : Error on rename ..... (errno: 20 "Not a directory" )

            The issue seems to be that mariabackup prepare expects the folder for the new schema to be already there, but it isn't because the schema is created after the full is taken, so can't be found in the full backup.

            This is critical as it breaks backup restores in presence of incrementals when the above condition is met (which is all but rare).

            How to repeat:

            1. take a full backup
            2. create a new schema and table
            3. take an incremental backup
            4. restore the full backup and then the incremental backup; prepare will crash






            julien.fritsch Julien Fritsch made changes -
            Assignee Alexander Barkov [ bar ]
            julien.fritsch Julien Fritsch made changes -
            Assignee Alexander Barkov [ bar ] Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]
            julien.fritsch Julien Fritsch made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.6 [ 24027 ]
            julien.fritsch Julien Fritsch made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] Alexander Barkov [ bar ]
            julien.fritsch Julien Fritsch made changes -
            Labels not-10.2
            julien.fritsch Julien Fritsch made changes -
            Labels not-10.2 not-10.2 not-10.3 not-10.4 not-10.5
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.9 [ 28001 ]
            julien.fritsch Julien Fritsch made changes -
            Affects Version/s 10.9 [ 28001 ]
            julien.fritsch Julien Fritsch made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            Component/s mariabackup [ 14500 ]
            Component/s mariabackup [ 14950 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.6 [ 24027 ]
            Fix Version/s 10.9 [ 28001 ]
            Key MENT-1476 MDEV-28446
            Affects Version/s 10.9 [ 26905 ]
            Affects Version/s 10.6.7-3 [ 27103 ]
            Affects Version/s 10.9 [ 28001 ]
            Project MariaDB Enterprise [ 11500 ] MariaDB Server [ 10000 ]
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            bar Alexander Barkov made changes -
            Labels not-10.2 not-10.3 not-10.4 not-10.5
            bar Alexander Barkov made changes -
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.7 [ 24805 ]
            Fix Version/s 10.8 [ 26121 ]
            bar Alexander Barkov made changes -
            Affects Version/s 10.2 [ 14601 ]
            Affects Version/s 10.3 [ 22126 ]
            Affects Version/s 10.4 [ 22408 ]
            Affects Version/s 10.5 [ 23123 ]
            Affects Version/s 10.6 [ 24028 ]
            Affects Version/s 10.7 [ 24805 ]
            Affects Version/s 10.8 [ 26121 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Alexander Barkov [ bar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            bar Alexander Barkov made changes -
            Fix Version/s 10.2.44 [ 27514 ]
            Fix Version/s 10.3.35 [ 27512 ]
            Fix Version/s 10.4.25 [ 27510 ]
            Fix Version/s 10.5.16 [ 27508 ]
            Fix Version/s 10.6.8 [ 27506 ]
            Fix Version/s 10.7.4 [ 27504 ]
            Fix Version/s 10.8.3 [ 27502 ]
            Fix Version/s 10.9.1 [ 27114 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.7 [ 24805 ]
            Fix Version/s 10.8 [ 26121 ]
            Fix Version/s 10.9 [ 26905 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            bar Alexander Barkov made changes -

            People

              bar Alexander Barkov
              rpizzi Rick Pizzi (Inactive)
              Votes:
              7 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.