Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28106

S3 tries to include thread.h while compiling on Windows

Details

    Description

      Usually S3 doesn't even try to build on Windows, because it wants CURL and it's almost never there. If, however, it does find CURL, it tries to build, but eventually fails with

        C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083:  Cannot open include file: 'pthread.h': No such file or directory [C:\_home\10.6x\storage\maria\s3.vcxproj]
      C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083: #include <pthread.h> [C:\_home\10.6x\storage\maria\s3.vcxproj]
      C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083:          ^ [C:\_home\10.6x\storage\maria\s3.vcxproj]
      

      I'm guessing it is missing ifdef or something – that is, if we want to build it on Windows at all, otherwise it should get skipped earlier.

      Attachments

        Issue Links

          Activity

            elenst Elena Stepanova created issue -
            elenst Elena Stepanova made changes -
            Field Original Value New Value
            elenst Elena Stepanova made changes -
            serg Sergei Golubchik made changes -
            Priority Minor [ 4 ] Blocker [ 1 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.5.16 [ 27508 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.7 [ 24805 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.6.8 [ 27506 ]
            Fix Version/s 10.7.4 [ 27504 ]

            People

              serg Sergei Golubchik
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.