[MDEV-28106] S3 tries to include thread.h while compiling on Windows Created: 2022-03-16  Updated: 2022-03-23  Resolved: 2022-03-23

Status: Closed
Project: MariaDB Server
Component/s: Compiling, Storage Engine - S3
Affects Version/s: 10.5, 10.6, 10.7, 10.8
Fix Version/s: 10.5.16, 10.6.8, 10.7.4

Type: Bug Priority: Blocker
Reporter: Elena Stepanova Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-28107 S3 doesn't build if CURL is in non-de... Closed
relates to MDEV-28104 Typo in storage/maria/s3_func.c: 'FN_... Closed

 Description   

Usually S3 doesn't even try to build on Windows, because it wants CURL and it's almost never there. If, however, it does find CURL, it tries to build, but eventually fails with

  C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083:  Cannot open include file: 'pthread.h': No such file or directory [C:\_home\10.6x\storage\maria\s3.vcxproj]
C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083: #include <pthread.h> [C:\_home\10.6x\storage\maria\s3.vcxproj]
C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083:          ^ [C:\_home\10.6x\storage\maria\s3.vcxproj]

I'm guessing it is missing ifdef or something – that is, if we want to build it on Windows at all, otherwise it should get skipped earlier.


Generated at Thu Feb 08 09:58:06 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.