Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27355

Fix UBSAN's Findings in Replication

Details

    Description

      UBSAN finds numerous issues in replication tests/code. This ticket is to document and fix these findings.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26272 The macro MASTER_INFO_VAR invokes undefined behaviour

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            elenst Elena Stepanova added a comment -

            Please also check with ps-protocol. Surprisingly, it seems to make a difference for replication/XA-related tests on UBSAN builds.

            elenst Elena Stepanova added a comment - Please also check with ps-protocol. Surprisingly, it seems to make a difference for replication/XA-related tests on UBSAN builds.
            bnestere Brandon Nesterenko added a comment -

            Went through 10.4 through 11.4 using GCC with and without --ps-protocol and found no more UBSAN failures in replication. Closing this ticket.

            Note though, that with the completion of MDEV-26272, Clang is now able to build MariaDB with UBSAN, and finds multiple issues in MariaDB with UBSAN overall (not seen by GCC). Future Clang specific findings to be fixed on an individual basis.

            bnestere Brandon Nesterenko added a comment - Went through 10.4 through 11.4 using GCC with and without --ps-protocol and found no more UBSAN failures in replication. Closing this ticket. Note though, that with the completion of MDEV-26272 , Clang is now able to build MariaDB with UBSAN, and finds multiple issues in MariaDB with UBSAN overall (not seen by GCC). Future Clang specific findings to be fixed on an individual basis.

            People

              bnestere Brandon Nesterenko
              bnestere Brandon Nesterenko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.