Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26875

Wrong user in SET DEFAULT ROLE error

Details

    Description

      The error message for SET DEFAULT ROLE refers to the user performing the operation instead of the target user. This is misleading as the user giving the grant doesn't require the grant itself, only the target user.

      Here's an example (and a test case) that reproduces the problem:

      MariaDB [test]> create role test_role;
      		 
      Query OK, 0 rows affected (0.000 sec)
      		 
       
      		 
      MariaDB [test]> create user test_user;
      		 
      Query OK, 0 rows affected (0.000 sec)
      		 
       
      		 
      MariaDB [test]> set default role test_role for test_user;
      		 
      ERROR 1959 (OP000): User `maxuser`@`127.0.0.1` has not been granted role `test_role`
      		 
      MariaDB [test]> grant test_role to maxuser@127.0.0.1;
      		 
      Query OK, 0 rows affected (0.000 sec)
      		 
       
      		 
      MariaDB [test]> set default role test_role for test_user;
      		 
      ERROR 1959 (OP000): User `maxuser`@`127.0.0.1` has not been granted role `test_role`
      		 
      MariaDB [test]> grant test_role to test_user;
      		 
      Query OK, 0 rows affected (0.000 sec)
      		 
       
      		 
      MariaDB [test]> set default role test_role for test_user;
      		 
      Query OK, 0 rows affected (0.000 sec)

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27478 Misleading error message for SET DEFAULT ROLE

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22312 Bad error message for SET DEFAULT ROLE when user account is not granted the role

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26081 set role crashes when a hostname cannot be resolved

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-6967 Wrong error code/message ER_INVALID_ROLE on setting a default role for non-existing user

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link PR 2362

          Activity

            Ascending order - Click to sort in descending order
            View 5 older comments
            anel Anel Husakovic added a comment -

            Hi Serg, yes I have update the test case for PR 2362

            anel Anel Husakovic added a comment - Hi Serg, yes I have update the test case for PR 2362
            serg Sergei Golubchik added a comment -

            https://github.com/MariaDB/server/pull/2362#discussion_r1270317522

            serg Sergei Golubchik added a comment - https://github.com/MariaDB/server/pull/2362#discussion_r1270317522
            anel Anel Husakovic added a comment - - edited

            Have updated PR 2362 per review.
            Added additional commit for testing the grants of anonymous user.

            anel Anel Husakovic added a comment - - edited Have updated PR 2362 per review. Added additional commit for testing the grants of anonymous user.
            serg Sergei Golubchik added a comment - - edited

            7349633b2c59 is ok to push

            you can squash both commits into one or commit separately, as you like

            serg Sergei Golubchik added a comment - - edited 7349633b2c59 is ok to push you can squash both commits into one or commit separately, as you like
            anel Anel Husakovic added a comment -

            Thanks pushed with ee773753778e741c.

            anel Anel Husakovic added a comment - Thanks pushed with ee773753778e741c .

            People

              anel Anel Husakovic
              markus makela markus makela
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.