Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26858

Spider: Remove dead code related to HandlerSocket

Details

    Description

      Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

      The following should be removed:

      • hs_client/* except hs_compat.h
      • spd_db_handlersocket.*
      • Any code protected by #ifdef HS_HAS_SQLCOM or #if defined(HS_HAS_SQLCOM) && ...

      Attachments

        Issue Links

          relates to

          New Feature - A new feature of the product, which has yet to be developed. MDEV-14510 Spider-Handlersocket

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. MDEV-28522 Delete constant SPIDER_SQL_TYPE_*_HS

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-28526 Spider: remove conn_kind member variables

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29027 ASAN errors in spider_db_free_result after partition DDL

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-30974 Remove SPIDER_DB_ACCESS_TYPE_NOSQL

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. MDEV-26178 Spider: remove unnecessary #ifdef and dead code in #ifdef

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) created issue -
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Field Original Value New Value
            Description Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

            The following should be removed:

            * {{hs_client/*}} except {{hs_compat.h}}
            * {{spd_db_handlersocket.*}}
            * The code protected by {{#if defined(HS_HAS_SQLCOM) && defined(HAVE_HANDLERSOCKET)}}.             		Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

            The following should be removed:

            * {{hs_client/*}} except {{hs_compat.h}}
            * {{spd_db_handlersocket.*}}
            * Any code protected by {{#if defined(HS_HAS_SQLCOM) && defined(HAVE_HANDLERSOCKET)}}.
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Description Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

            The following should be removed:

            * {{hs_client/*}} except {{hs_compat.h}}
            * {{spd_db_handlersocket.*}}
            * Any code protected by {{#if defined(HS_HAS_SQLCOM) && defined(HAVE_HANDLERSOCKET)}}.             		Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

            The following should be removed:

            * {{hs_client/*}} except {{hs_compat.h}}
            * {{spd_db_handlersocket.*}}
            * Any code protected by ...
            ** {{#if defined(HS_HAS_SQLCOM) && defined(HAVE_HANDLERSOCKET)}}
            ** {{#ifdef SQLCOM_HS_DELETE}}
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Description Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

            The following should be removed:

            * {{hs_client/*}} except {{hs_compat.h}}
            * {{spd_db_handlersocket.*}}
            * Any code protected by ...
            ** {{#if defined(HS_HAS_SQLCOM) && defined(HAVE_HANDLERSOCKET)}}
            ** {{#ifdef SQLCOM_HS_DELETE}}             		Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

            The following should be removed:

            * {{hs_client/*}} except {{hs_compat.h}}
            * {{spd_db_handlersocket.*}}
            * Any code protected by {{#if defined(HS_HAS_SQLCOM) && defined(HAVE_HANDLERSOCKET)}}
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Description Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

            The following should be removed:

            * {{hs_client/*}} except {{hs_compat.h}}
            * {{spd_db_handlersocket.*}}
            * Any code protected by {{#if defined(HS_HAS_SQLCOM) && defined(HAVE_HANDLERSOCKET)}}             		Remove the dead-code, in Spider, which is related to the Spider's HandlerSocket support. The code has been disabled for a long time and it is unlikely that the code will be enabled.

            The following should be removed:

            * {{hs_client/*}} except {{hs_compat.h}}
            * {{spd_db_handlersocket.*}}
            * Any code protected by {{#ifdef HS_HAS_SQLCOM}} or {{#if defined(HS_HAS_SQLCOM) && ...}}
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

            Please review: https://github.com/MariaDB/server/commit/d8b873e945683ce1be9e705ce6bdbe7d4af1d3ab

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - Please review: https://github.com/MariaDB/server/commit/d8b873e945683ce1be9e705ce6bdbe7d4af1d3ab
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Assignee Nayuta Yanagisawa [ JIRAUSER47117 ] Alexey Botchkov [ holyfoot ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 126382 ] MariaDB v4 [ 131786 ]
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            holyfoot Alexey Botchkov made changes -
            Assignee Alexey Botchkov [ holyfoot ] Nayuta Yanagisawa [ JIRAUSER47117 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

            Thank you!

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - Thank you!
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Assignee Nayuta Yanagisawa [ JIRAUSER47117 ] Sergei Golubchik [ serg ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Assignee Sergei Golubchik [ serg ] Nayuta Yanagisawa [ JIRAUSER47117 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Assignee Nayuta Yanagisawa [ JIRAUSER47117 ] Roel Van de Paar [ roel ]
            Roel Roel Van de Paar made changes -
            Status Stalled [ 10000 ] In Testing [ 10301 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Status In Testing [ 10301 ] Closed [ 6 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Assignee Roel Van de Paar [ roel ] Nayuta Yanagisawa [ JIRAUSER47117 ]
            Status Closed [ 6 ] Stalled [ 10000 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Fix Version/s 10.8.1 [ 26815 ]
            Fix Version/s 10.8 [ 26121 ]
            Resolution Done [ 10200 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            Fix Version/s 10.6.19 [ 29833 ]
            Fix Version/s 10.5.26 [ 29832 ]
            ycp Yuchen Pei added a comment -

            Note that the patches were backported to 10.5.26 and 10.6.19 as a part of MDEV-29027

            ycp Yuchen Pei added a comment - Note that the patches were backported to 10.5.26 and 10.6.19 as a part of MDEV-29027

            People

              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.