Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28522

Delete constant SPIDER_SQL_TYPE_*_HS

Details

    Description

      HandlerSocket support of Spider has been deleted by MDEV-26858. Thus, the constants, SPIDER_SQL_TYPE_*_HS, are no longer necessary.

      Some functions for maintaining Spider tables take SPIDER_SQL_TYPE_OTHER_HS as arguments but this seems not to make sense.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29027 ASAN errors in spider_db_free_result after partition DDL

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-26858 Spider: Remove dead code related to HandlerSocket

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 5 older comments
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

            https://github.com/MariaDB/server/commit/422fb63a9bbee35c50b6c7be19d199afe0bc98fa

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - https://github.com/MariaDB/server/commit/422fb63a9bbee35c50b6c7be19d199afe0bc98fa
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            Branch 11.1 does not exist yet, so we have to wait before pushing.

            ycp Yuchen Pei added a comment - Branch 11.1 does not exist yet, so we have to wait before pushing.
            ycp Yuchen Pei added a comment -

            Pushed to 11.1

            ycp Yuchen Pei added a comment - Pushed to 11.1
            ycp Yuchen Pei added a comment -

            Note that the patches were backported to 10.5.26 and 10.6.19 and 10.11.9 as a part of MDEV-29027

            ycp Yuchen Pei added a comment - Note that the patches were backported to 10.5.26 and 10.6.19 and 10.11.9 as a part of MDEV-29027

            People

              ycp Yuchen Pei
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.