Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28526

Spider: remove conn_kind member variables

Details

    Description

      The conn_kind, which stands for "connection kind", is no longer useful because the HandlerSocket support is deleted and Spider now has only one connection kind, SPIDER_CONN_KIND_MYSQL. Remove conn_kind and related code.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-26858 Spider: Remove dead code related to HandlerSocket

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 5 older comments
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

            ycp I've commented on GitHub: https://github.com/MariaDB/server/commit/ed3488e3ed040cf27ac3017090dce9bedcc43c8c#

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - ycp I've commented on GitHub: https://github.com/MariaDB/server/commit/ed3488e3ed040cf27ac3017090dce9bedcc43c8c#
            ycp Yuchen Pei added a comment - - edited

            nayuta-yanagisawa
            Just applied formatting with `git diff -U0 --no-color --relative HEAD^ | clang-format-diff -p1 -i`, and did a sanity check on the result which looked alright to me. PTAL thanks:

            https://github.com/MariaDB/server/commit/b7b4375fe73840c5f7e0fc02ee00e51f6e2ae550-

            Sorry, should be this one:

            -htt            ps://github.com/MariaDB/server/commit/b1ee3d2d08fa5a39dd4fdddfa907bb92b1362356

            Sorry, just noticed there's another comment to address. Working on it.

            ycp Yuchen Pei added a comment - - edited nayuta-yanagisawa Just applied formatting with `git diff -U0 --no-color --relative HEAD^ | clang-format-diff -p1 -i`, and did a sanity check on the result which looked alright to me. PTAL thanks: htt ps://github.com/MariaDB/server/commit/b7b4375fe73840c5f7e0fc02ee00e51f6e2ae550- Sorry, should be this one: -htt ps://github.com/MariaDB/server/commit/b1ee3d2d08fa5a39dd4fdddfa907bb92b1362356 Sorry, just noticed there's another comment to address. Working on it.
            ycp Yuchen Pei added a comment -

            nayuta-yanagisawa
            Addressed both comments, updated commit at:

            https://github.com/MariaDB/server/commit/ff19638d863a137acc76ec089d495d8afe3eef20

            ycp Yuchen Pei added a comment - nayuta-yanagisawa Addressed both comments, updated commit at: https://github.com/MariaDB/server/commit/ff19638d863a137acc76ec089d495d8afe3eef20
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

            OK to push but please hold on until the latest development branch is created.

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - OK to push but please hold on until the latest development branch is created.
            ycp Yuchen Pei added a comment -

            backported to 10.5 as part of MDEV-34849

            ycp Yuchen Pei added a comment - backported to 10.5 as part of MDEV-34849

            People

              ycp Yuchen Pei
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.