Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.5, 10.6, 10.7(EOL)
Description
MDEV-25113 removed the acquisition of buf_pool.flush_list_mutex from buf_page_write_complete(). But, acquiring buf_pool.mutex should not really be necessary except in eviction flushing (request.is_LRU()) or when the block->lock is not available (no uncompressed copy of a ROW_FORMAT=COMPRESSED exists in the buffer pool).
In the common case of checkpoint flushing, we can actually rely on the block->lock to protect us. The only other reason to hold buf_pool.mutex was updating the count of outstanding page writes (buf_pool.n_flush_list()). That counter is actually redundant, because we can refer to write_slots->pending_io_count().
Finally, we would remove pthread_cond_broadcast(&buf_pool.done_flush_list) from buf_page_write_complete(). Only the buf_flush_page_cleaner would call that. To wait for page writes to complete, os_aio_wait_until_no_pending_writes() may be invoked.
Interface change:
New parameter Innodb_buffer_pool_pages_split has been added
Attachments
Issue Links
- blocks
-
MDEV-16526 Overhaul the InnoDB page flushing
-
- Closed
-
-
-
- Closed
-
- causes
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
- is blocked by
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
- relates to
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue is blocked by |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Link |
This issue blocks |
| Assignee | Marko Mäkelä [ marko ] | Vladislav Vaintroub [ wlad ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Assignee | Vladislav Vaintroub [ wlad ] | Marko Mäkelä [ marko ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Link |
This issue blocks |
| Link |
This issue blocks |
| Status | Stalled [ 10000 ] | In Progress [ 3 ] |
| Link |
This issue is blocked by |
| Workflow | MariaDB v3 [ 126232 ] | MariaDB v4 [ 144614 ] |
| Link |
This issue relates to |
| Fix Version/s | 10.7 [ 24805 ] |
| issue.field.resolutiondate | 2023-03-16 15:39:12.0 | 2023-03-16 15:39:12.947 |
| Fix Version/s | 10.6.13 [ 28514 ] | |
| Fix Version/s | 10.8.8 [ 28518 ] | |
| Fix Version/s | 10.9.6 [ 28520 ] | |
| Fix Version/s | 10.10.4 [ 28522 ] | |
| Fix Version/s | 10.11.3 [ 28524 ] | |
| Fix Version/s | 11.0.2 [ 28706 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Link |
This issue is blocked by |
| Link |
This issue relates to |
| Link |
This issue causes |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Link |
This issue causes |
| Link |
This issue causes |
| Link |
This issue causes |
| Link |
This issue relates to |
| Link |
This issue causes |
| Link |
This issue relates to |
| Description |
In the common case of checkpoint flushing, we can actually rely on the {{block->lock}} to protect us. The only other reason to hold {{buf_pool.mutex}} was updating the count of outstanding page writes ({{buf_pool.n_flush_list()}}). That counter is actually redundant, because we can refer to {{write_slots->pending_io_count()}}. Finally, we would remove {{pthread_cond_broadcast(&buf_pool.done_flush_list)}} from {{buf_page_write_complete()}}. Only the {{buf_flush_page_cleaner}} would call that. To wait for page writes to complete, {{os_aio_wait_until_no_pending_writes()}} may be invoked. |
In the common case of checkpoint flushing, we can actually rely on the {{block->lock}} to protect us. The only other reason to hold {{buf_pool.mutex}} was updating the count of outstanding page writes ({{buf_pool.n_flush_list()}}). That counter is actually redundant, because we can refer to {{write_slots->pending_io_count()}}. Finally, we would remove {{pthread_cond_broadcast(&buf_pool.done_flush_list)}} from {{buf_page_write_complete()}}. Only the {{buf_flush_page_cleaner}} would call that. To wait for page writes to complete, {{os_aio_wait_until_no_pending_writes()}} may be invoked. Interface change: New parameter Innodb_buffer_pool_pages_split has been added |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Link |
This issue causes |
| Link |
This issue relates to |
| Link |
This issue causes |
| Link |
This issue relates to |
| Link |
This issue causes |
| Link |
This issue causes |
| Link |
This issue relates to |
| Link |
This issue blocks |
| Link |
This issue causes |
| Link |
This issue causes |
| Link |
This issue causes |