Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26827

Make page flushing even faster

    XMLWordPrintable

Details

    Description

      MDEV-25113 removed the acquisition of buf_pool.flush_list_mutex from buf_page_write_complete(). But, acquiring buf_pool.mutex should not really be necessary except in eviction flushing (request.is_LRU()) or when the block->lock is not available (no uncompressed copy of a ROW_FORMAT=COMPRESSED exists in the buffer pool).

      In the common case of checkpoint flushing, we can actually rely on the block->lock to protect us. The only other reason to hold buf_pool.mutex was updating the count of outstanding page writes (buf_pool.n_flush_list()). That counter is actually redundant, because we can refer to write_slots->pending_io_count().

      Finally, we would remove pthread_cond_broadcast(&buf_pool.done_flush_list) from buf_page_write_complete(). Only the buf_flush_page_cleaner would call that. To wait for page writes to complete, os_aio_wait_until_no_pending_writes() may be invoked.

      Interface change:
      New parameter Innodb_buffer_pool_pages_split has been added

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-16526 Overhaul the InnoDB page flushing

          • Major - Major loss of function.
          • Closed
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30900 MacOS Crash when testing

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31084 Assertion `waiting' failed in TP_connection_generic::wait_end

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31114 Assertion `!tls_worker_data->is_waiting()' in tpool::thread_pool_generic::wait_begin

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31309 The status variable Innodb_buffer_pool_read_requests is not updated correctly

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31350 test innodb.recovery_memory failed on '21 failed attempts to flush a page'

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32029 Assertion failures in log_sort_flush_list upon crash recovery

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-25113 Reduce effect of parallel background flush on select workload

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26055 Adaptive flushing is still not getting invoked in 10.5.11

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27058 Buffer page descriptors are too large

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28052 test main.implicit_commit crashed on sparc64

          • Major - Major loss of function.
          • Needs Feedback

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31048 InnoDB read_slots and write_slots are missing PERFORMANCE_SCHEMA instrumentation

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32134 InnoDB hang in buf_flush_wait_LRU_batch_end()

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26004 Excessive wait times in buf_LRU_get_free_block()

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31350 test innodb.recovery_memory failed on '21 failed attempts to flush a page'

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.