Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26467

Unnecessary compare-and-swap loop in futex-based synchronization

Details

    Description

      In the futex-based implementation of InnoDB synchronization primitives srw_mutex::wait_and_lock() we are unnecessarily using a compare-and-swap loop for setting the HOLDER flag. We could use a fetch_add (to register the current thread as a waiter) followed by a fetch_or to set the flag. The value of a granted lock word with no waiting threads would change from HOLDER to HOLDER + 1.

      Replacing the compare-and-swap loop seems to slightly improve performance in Sysbench oltp_update_index on my AMD64 based system, using a single NUMA node:

      threads unpatched transactions/s patched transactions/s
      10 91110 92171
      20 158399 158623
      30 162566 163092

      We still use a compare-and-swap loop in ssux_lock_low::rd_lock_try() ever since MDEV-24271. It used to be a greedy fetch_add() followed by a fetch_sub() back-off, but we observed starvation due to that.

      Attachments

        1. 1064.vs.MDEV-26467.png
          61 kB
          Krunal Bauskar
        2. oltp_update_non_index.png
          41 kB
          Axel Schwenke

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26720 Suboptimal translation of single-bit std::atomic::fetch_or() and fetch_and()

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24142 rw_lock_t has unnecessarily complex wait logic

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25404 read-only performance regression in 10.6

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Task - A task that needs to be done. MDEV-32065 Always check whether lock is free at first to optimize InnoDB mutexes

          • Major - Major loss of function.
          • Open

          Activity

            Transition Time In Source Status Execution Times
            Marko Mäkelä made transition -
            Open In Progress
            		9m 4s 1
            Marko Mäkelä made transition -
            In Progress Closed
            		13d 6h 14m 1

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.