[MDEV-26340] rsync uses `--whole-file` only in wan mode - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.5.11, 10.2.40, 10.3.31, 10.4.21, 10.6.4, 10.7(EOL)
Fix Version/s: 10.2.41, 10.3.32, 10.4.22, 10.5.13, 10.6.5, 10.7.0
Component/s: Galera SST
Labels:
None

Description

Please see my comments here: https://github.com/MariaDB/server/commit/2fb4407827ecd6cbf52e210a8d9370b4560ddd5b#r54688038

The recent commit https://github.com/MariaDB/server/commit/2fb4407827ecd6cbf52e210a8d9370b4560ddd5b switched the logic of a conditional, most likely by mistake.

According to the comment inside the sst script, --whole-file should only be used for LAN transfers, but not in WAN mode. This is not the case anymore. --whole-file is now exclusively used for WAN transfers.

Attachments

Activity

Ascending order - Click to sort in descending order

Jan Lindström (Inactive) added a comment - 2021-08-16 04:39

ok to push

Jan Lindström (Inactive) added a comment - 2021-08-16 04:39 ok to push

Julius Goryavsky added a comment - 2021-08-16 09:04

Fixed, https://github.com/MariaDB/server/commit/094e03916670891b87ef1d95cf52ce6248c537ed

Julius Goryavsky added a comment - 2021-08-16 09:04 Fixed, https://github.com/MariaDB/server/commit/094e03916670891b87ef1d95cf52ce6248c537ed

People

Assignee:: Julius Goryavsky

Reporter:: Christian Ciach

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2021-08-10 18:26

Updated:: 2021-08-16 09:14

Resolved:: 2021-08-16 09:04

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server