[MDEV-26340] rsync uses `--whole-file` only in wan mode Created: 2021-08-10 Updated: 2021-08-16 Resolved: 2021-08-16 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Galera SST |
| Affects Version/s: | 10.2.40, 10.3.31, 10.4.21, 10.5.11, 10.6.4, 10.7 |
| Fix Version/s: | 10.2.41, 10.3.32, 10.4.22, 10.5.13, 10.6.5, 10.7.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Christian Ciach | Assignee: | Julius Goryavsky |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Please see my comments here: https://github.com/MariaDB/server/commit/2fb4407827ecd6cbf52e210a8d9370b4560ddd5b#r54688038 The recent commit https://github.com/MariaDB/server/commit/2fb4407827ecd6cbf52e210a8d9370b4560ddd5b switched the logic of a conditional, most likely by mistake. According to the comment inside the sst script, --whole-file should only be used for LAN transfers, but not in WAN mode. This is not the case anymore. --whole-file is now exclusively used for WAN transfers. |
| Comments |
| Comment by Jan Lindström (Inactive) [ 2021-08-16 ] |
|
ok to push |
| Comment by Julius Goryavsky [ 2021-08-16 ] |
|
Fixed, https://github.com/MariaDB/server/commit/094e03916670891b87ef1d95cf52ce6248c537ed |