Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26137

ALTER TABLE IMPORT enhancement

Details

    Description

      The feature introduces simplified workflow:

      FLUSH TABLES t1 FOR EXPORT;
      		 
      --copy_file $MYSQLD_DATADIR/test/t1.cfg $MYSQLD_DATADIR/test/t2.cfg
      		 
      --copy_file $MYSQLD_DATADIR/test/t1.frm $MYSQLD_DATADIR/test/t2.frm
      		 
      --copy_file $MYSQLD_DATADIR/test/t1.ibd $MYSQLD_DATADIR/test/t2.ibd
      		 
      UNLOCK TABLES;
      		 
      ALTER TABLE t2 IMPORT TABLESPACE;

      Previously, CREATE TABLE and ALTER TABLE…DISCARD TABLESPACE had to be executed, and the exact table definition from an existing .frm file could not be reused. This simplification addresses MDEV-15225.

      ha_innodb::open() should check for .ibd and .cfg files before actually opening a table.

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. MDEV-11658 Simpler, faster IMPORT of InnoDB tables

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-15225 Can't import .ibd file with temporal type format differing from mysql56_temporal_format

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-18762 Support easy restore of partial backup

          • Major - Major loss of function.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-31010 Q2 2023 release merge

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          New Feature - A new feature of the product, which has yet to be developed. MDEV-33226 ALTER TABLE IMPORT enhancement for Partitioned tables

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. MDEV-10568 Implement support for ALTER TABLE ... {DISCARD|IMPORT} PARTITION

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-15225 Can't import .ibd file with temporal type format differing from mysql56_temporal_format

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26155 Mangled data after IMPORT tablespace up till assert for DDL

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            View 29 older comments
            ycp Yuchen Pei added a comment -

            Thanks for the suggestion marko. I looked into
            innodb.page_cleaner, studied the relevant variables, and made an
            attempt towards that direction[1], but given I am not able to
            reproduce the failure locally, I cannot tell whether it would work
            without waiting for the CI

            [1] https://github.com/MariaDB/server/commit/e8c2d177d76

            ycp Yuchen Pei added a comment - Thanks for the suggestion marko . I looked into innodb.page_cleaner , studied the relevant variables, and made an attempt towards that direction [1] , but given I am not able to reproduce the failure locally, I cannot tell whether it would work without waiting for the CI [1] https://github.com/MariaDB/server/commit/e8c2d177d76
            ycp Yuchen Pei added a comment -

            Updated patch at https://github.com/MariaDB/server/commit/f3d86acf1fe, checking CI...

            ycp Yuchen Pei added a comment - Updated patch at https://github.com/MariaDB/server/commit/f3d86acf1fe , checking CI...
            ycp Yuchen Pei added a comment -

            Squashed the following 32bit fixup and import_recovery fixup commits
            (see the list below) into https://github.com/MariaDB/server/commit/9b431d714fd

            ycp Yuchen Pei added a comment - Squashed the following 32bit fixup and import_recovery fixup commits (see the list below) into https://github.com/MariaDB/server/commit/9b431d714fd https://github.com/MariaDB/server/commit/056c83cc8f9551aa861dd9a3327584c8790562cd https://github.com/MariaDB/server/commit/861431e1f88c4e24d7dab311358196d78f28e1e7 https://github.com/MariaDB/server/commit/9315fe5c5b0421fd4ef7c8009e82b8f0b31c8582 https://github.com/MariaDB/server/commit/f3d86acf1fe29af3e3c4b3c4165b6e789eb018d8
            marko Marko Mäkelä added a comment -

            Thank you, this looks good to me.

            marko Marko Mäkelä added a comment - Thank you, this looks good to me.
            ycp Yuchen Pei added a comment -

            Pushed 9b431d714fdf030e372ed6eeaec0619dcffdde6a to 11.2, closing

            ycp Yuchen Pei added a comment - Pushed 9b431d714fdf030e372ed6eeaec0619dcffdde6a to 11.2, closing

            People

              ycp Yuchen Pei
              kevg Eugene Kosov (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.