Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-25878

mytop bugs: check for mysql driver and sockets

Details

    Description

      Use DBD::mysql driver in case if DBD::mariadb is not installed and use correct socket name for MariaDB/Mysql driver respectively.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          anel Anel Husakovic added a comment - - edited

          serg can you please review http://github.com/MariaDB/server/tree/bb-10.5-anel-MDEV-25878-mytop - 2 commits (not sure should it be in 10.6 though ) ?
          Although you already gave suggestions for it in MDEV-22552, but I added this as separate MDEV.

          anel Anel Husakovic added a comment - - edited serg can you please review http://github.com/MariaDB/server/tree/bb-10.5-anel-MDEV-25878-mytop - 2 commits (not sure should it be in 10.6 though ) ? Although you already gave suggestions for it in MDEV-22552 , but I added this as separate MDEV.
          serg Sergei Golubchik added a comment -
          • the first commit comment says "Apply 1546", better say "Apply #1546", so that it would auto-link to the PR
          • moving mytop from server to client component is wrong:
            • it logically doesn't belong to the MDEV with the title "mytop bugs: check for mysql driver and sockets"
            • it is incomplete, should also cover Debian and should include proper breaks/replaces/conflicts

          better keep the packaging part in MDEV-22552, and here only fix the script code to try both drivers.

          serg Sergei Golubchik added a comment - the first commit comment says "Apply 1546", better say "Apply #1546", so that it would auto-link to the PR moving mytop from server to client component is wrong: it logically doesn't belong to the MDEV with the title "mytop bugs: check for mysql driver and sockets" it is incomplete, should also cover Debian and should include proper breaks/replaces/conflicts better keep the packaging part in MDEV-22552 , and here only fix the script code to try both drivers.
          serg Sergei Golubchik added a comment -

          https://github.com/MariaDB/server/commit/7e14913a5f and https://github.com/MariaDB/server/commit/e891aa5fc4 are ok to push

          serg Sergei Golubchik added a comment - https://github.com/MariaDB/server/commit/7e14913a5f and https://github.com/MariaDB/server/commit/e891aa5fc4 are ok to push
          anel Anel Husakovic added a comment -

          Pushed, thanks Serg.

          anel Anel Husakovic added a comment - Pushed, thanks Serg.

          People

            anel Anel Husakovic
            anel Anel Husakovic
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.