Anel Husakovic added a comment - 2021-06-09 11:10 otto serg thank you for your review. From 5 commits in my working branch I removed 3 in new MDEV-25878 (what is not related to the description - mytop in RPM). Commits that are left currently in working branch are: 1. https://github.com/MariaDB/server/commit/ca1d0edac9f61202b8249583cffb39ba30eb73a0 ^ moving my_print_defaults to client component - RPM change 2. https://github.com/MariaDB/server/commit/87f91f4314d6c8b591a29fd8c89db6fedb6e1953 ^ otto patch from PR #1581 that is obsolete/(part of the patch is pushed) to 10.5.2+ now. The state of mytop regarding debian in MariaDB server: 10.5.2+: mytop moved to mariadb-client-10.5 package: http://github.com/MariaDB/server/commit/e0e5d8c5942a1eb0b0ae05b6296286193073e571 10.5.3+: mariadb-client-10.5 conflicts with mytop: https://github.com/MariaDB/server/commit/9ed7e967b3fe 10.6.0+ moved my_print_defaults from server-core -> client-core in 10.6 since mytop requires it: https://github.com/MariaDB/server/commit/fc65417e7bcae88f15e1bfcd0ccebf1b06e02fd5 So mytop is already in mariadb-client package from 10.5+ and my_print_defaults in client-core package from 10.6+. otto I don't plan to touch debian/ here regarding mytop on 10.5. If there is something to do (don't see what could be ? - adding perl5-DBD-mysql/MariaDB dependency?) beside above analysis please create new MDEV for mytop and debian for 10.6 and please explain me what needs to be done. serg commented your patch (PR #1581) for relations between mariadb-client-core and mariadb-server package that I had in my branch. This change is visible in 10.6. now. serg based on debian-policy there is suggestion if there is breaks rule it should go in conjuction with replaces . Replaces rule https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces doc says: It is usually an error for a package to contain files which are on the system in another package. However, if the overwriting package declares that it Replaces the one containing the file being overwritten, then dpkg will replace the file from the old package with that from the new. The file will no longer be listed as “owned” by the old package and will be taken over by the new package. Normally, Breaks should be used in conjunction with Replaces. I think we should add Conflicts in addition which is a stronger constraint compared to breaks -> otto ?! I will push soon patch for RPM only I guess 10.5 is ok to be target branch in this case.

Otto Kekäläinen added a comment - 2021-06-09 15:10 I think we should add Conflicts in addition which is a stronger constraint compared to breaks -> Otto Kekäläinen?! I did a thorough testing and cleanup of breaks/replaces/conflicts in https://github.com/MariaDB/server/commit/62f5a4f06529008b06858c40a8cad419bf4921a3 For MariaDB 10.6 no further changes are needed and for 10.5 and older I would not touch them at this point. It is good to follow the Debian policy but most importantly we need to test and verify that in our specific case the upgrades actually proceed correctly in every conceivable scenario, and that I've done for 10.6.

Anel Husakovic added a comment - 2021-06-23 08:40 Hi serg can you please review 2 commits bb-10.5-anel-MDEV-22552 . Testing result, analysis and some question for you additionally (not related to patch) can be found in Zulip CentOS thread .

Sergei Golubchik added a comment - 2021-07-12 15:34 looks good

Anel Husakovic added a comment - 2021-10-26 09:40 Pushed to 10.5 with commits 2011fcf87ddb0dc and 395a033237686f2