[MDEV-25878] mytop bugs: check for mysql driver and sockets Created: 2021-06-08  Updated: 2021-06-22  Resolved: 2021-06-21

Status: Closed
Project: MariaDB Server
Component/s: Scripts & Clients
Affects Version/s: 10.5
Fix Version/s: 10.5.12, 10.6.3

Type: Bug Priority: Minor
Reporter: Anel Husakovic Assignee: Anel Husakovic
Resolution: Fixed Votes: 0
Labels: None


 Description   

Use DBD::mysql driver in case if DBD::mariadb is not installed and use correct socket name for MariaDB/Mysql driver respectively.

 Comments   
Comment by Anel Husakovic [ 2021-06-09 ]

serg can you please review http://github.com/MariaDB/server/tree/bb-10.5-anel-MDEV-25878-mytop - 2 commits (not sure should it be in 10.6 though ) ?
Although you already gave suggestions for it in MDEV-22552, but I added this as separate MDEV.

Comment by Sergei Golubchik [ 2021-06-10 ]
  • the first commit comment says "Apply 1546", better say "Apply #1546", so that it would auto-link to the PR
  • moving mytop from server to client component is wrong:
    • it logically doesn't belong to the MDEV with the title "mytop bugs: check for mysql driver and sockets"
    • it is incomplete, should also cover Debian and should include proper breaks/replaces/conflicts

better keep the packaging part in MDEV-22552, and here only fix the script code to try both drivers.

Comment by Sergei Golubchik [ 2021-06-21 ]

https://github.com/MariaDB/server/commit/7e14913a5f and https://github.com/MariaDB/server/commit/e891aa5fc4 are ok to push

Comment by Anel Husakovic [ 2021-06-21 ]

Pushed, thanks Serg.

Generated at Thu Feb 08 09:41:05 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.