As suggested, I implemented this at the end of bb-10.10-MDEV-25704 and tested for mysql 8,0 compatibility. select random_bytes(0) is our extension. Note the fixme on TIME conversion in the test. Suggestions on implementing this much appreciated.
Daniel Black
added a comment - As suggested, I implemented this at the end of bb-10.10- MDEV-25704 and tested for mysql 8,0 compatibility. select random_bytes(0) is our extension. Note the fixme on TIME conversion in the test. Suggestions on implementing this much appreciated.
fixed most. Debug builds only of query_cache test failing because args[0]->can_eval_in_optimize() changes from false to true between Item_func_random_bytes::fix_length_and_dec and Item_func_random_bytes::val_str. This is due to args[0]->table->const_table becoming true.
Daniel Black
added a comment - - edited fixed most. Debug builds only of query_cache test failing because args[0]->can_eval_in_optimize() changes from false to true between Item_func_random_bytes::fix_length_and_dec and Item_func_random_bytes::val_str . This is due to args[0]->table->const_table becoming true.
Daniel Black
added a comment - Ok, buildbot happy again. serg , nikitamalyavin can I get a review on the last two commits on the bb-10.10- MDEV-25704 branch.
I have no further objections against pushing bb-10.10-MDEV-25704 as of 7f422495 into 10.10 main and releasing it with 10.10.1.
Elena Stepanova
added a comment - I have no further objections against pushing bb-10.10- MDEV-25704 as of 7f422495 into 10.10 main and releasing it with 10.10.1.
People
Sergei Golubchik
Ian Gilfillan
Votes:
0Vote for this issue
Watchers:
9Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":860.9000000953674,"ttfb":165.5,"pageVisibility":"visible","entityId":99720,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"646aa9e1-8f9b-409a-8497-c864f912f466","navigationType":0,"readyForUser":939.2000000476837,"redirectCount":0,"resourceLoadedEnd":559.2000000476837,"resourceLoadedStart":175,"resourceTiming":[{"duration":37.300000071525574,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":175,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":175,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":212.30000007152557,"responseStart":0,"secureConnectionStart":0},{"duration":38.300000071525574,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":175.60000002384186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":175.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":213.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":233.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":175.80000007152557,"connectEnd":175.80000007152557,"connectStart":175.80000007152557,"domainLookupEnd":175.80000007152557,"domainLookupStart":175.80000007152557,"fetchStart":175.80000007152557,"redirectEnd":0,"redirectStart":0,"requestStart":221,"responseEnd":409.40000009536743,"responseStart":248.40000009536743,"secureConnectionStart":175.80000007152557},{"duration":382.39999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":176.80000007152557,"connectEnd":176.80000007152557,"connectStart":176.80000007152557,"domainLookupEnd":176.80000007152557,"domainLookupStart":176.80000007152557,"fetchStart":176.80000007152557,"redirectEnd":0,"redirectStart":0,"requestStart":221.60000002384186,"responseEnd":559.2000000476837,"responseStart":281,"secureConnectionStart":176.80000007152557},{"duration":78.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":177,"connectEnd":177,"connectStart":177,"domainLookupEnd":177,"domainLookupStart":177,"fetchStart":177,"redirectEnd":0,"redirectStart":0,"requestStart":223.10000002384186,"responseEnd":255.60000002384186,"responseStart":249.80000007152557,"secureConnectionStart":177},{"duration":78.89999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":177.20000004768372,"connectEnd":177.20000004768372,"connectStart":177.20000004768372,"domainLookupEnd":177.20000004768372,"domainLookupStart":177.20000004768372,"fetchStart":177.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":226.80000007152557,"responseEnd":256.10000002384186,"responseStart":252.20000004768372,"secureConnectionStart":177.20000004768372},{"duration":79,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":177.40000009536743,"connectEnd":177.40000009536743,"connectStart":177.40000009536743,"domainLookupEnd":177.40000009536743,"domainLookupStart":177.40000009536743,"fetchStart":177.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":227.10000002384186,"responseEnd":256.40000009536743,"responseStart":253,"secureConnectionStart":177.40000009536743},{"duration":46.800000071525574,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":177.60000002384186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":177.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":224.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":93.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":177.80000007152557,"connectEnd":177.80000007152557,"connectStart":177.80000007152557,"domainLookupEnd":177.80000007152557,"domainLookupStart":177.80000007152557,"fetchStart":177.80000007152557,"redirectEnd":0,"redirectStart":0,"requestStart":230.5,"responseEnd":271.60000002384186,"responseStart":269.5,"secureConnectionStart":177.80000007152557},{"duration":48.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":178,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":178,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":226.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":95.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":178.10000002384186,"connectEnd":178.10000002384186,"connectStart":178.10000002384186,"domainLookupEnd":178.10000002384186,"domainLookupStart":178.10000002384186,"fetchStart":178.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":234.10000002384186,"responseEnd":273.8000000715256,"responseStart":270,"secureConnectionStart":178.10000002384186},{"duration":372.10000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":181.5,"connectEnd":181.5,"connectStart":181.5,"domainLookupEnd":181.5,"domainLookupStart":181.5,"fetchStart":181.5,"redirectEnd":0,"redirectStart":0,"requestStart":276.3000000715256,"responseEnd":553.6000000238419,"responseStart":545.5,"secureConnectionStart":181.5},{"duration":374.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":181.5,"connectEnd":181.5,"connectStart":181.5,"domainLookupEnd":181.5,"domainLookupStart":181.5,"fetchStart":181.5,"redirectEnd":0,"redirectStart":0,"requestStart":329.2000000476837,"responseEnd":555.7000000476837,"responseStart":552.1000000238419,"secureConnectionStart":181.5},{"duration":154.39999997615814,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":555.8000000715256,"connectEnd":555.8000000715256,"connectStart":555.8000000715256,"domainLookupEnd":555.8000000715256,"domainLookupStart":555.8000000715256,"fetchStart":555.8000000715256,"redirectEnd":0,"redirectStart":0,"requestStart":677.1000000238419,"responseEnd":710.2000000476837,"responseStart":708.9000000953674,"secureConnectionStart":555.8000000715256},{"duration":195.79999995231628,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":806.7000000476837,"connectEnd":806.7000000476837,"connectStart":806.7000000476837,"domainLookupEnd":806.7000000476837,"domainLookupStart":806.7000000476837,"fetchStart":806.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":970.2000000476837,"responseEnd":1002.5,"responseStart":1001.5,"secureConnectionStart":806.7000000476837},{"duration":187.19999992847443,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":854.4000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":854.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1041.6000000238419,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":4,"responseStart":166,"responseEnd":181,"domLoading":170,"domInteractive":1048,"domContentLoadedEventStart":1048,"domContentLoadedEventEnd":1101,"domComplete":1420,"loadEventStart":1420,"loadEventEnd":1421,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1016.7000000476837},{"name":"bigPipe.sidebar-id.end","time":1017.6000000238419},{"name":"bigPipe.activity-panel-pipe-id.start","time":1017.8000000715256},{"name":"bigPipe.activity-panel-pipe-id.end","time":1019.4000000953674},{"name":"activityTabFullyLoaded","time":1122.5}],"measures":[],"correlationId":"8bd936ddf7431e","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":100,"dbReadsTimeInMs":16,"dbConnsTimeInMs":26,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Task
Minor
MDEV-29028 Queries using RANDOM_BYTES get stored in query cache
As suggested, I implemented this at the end of bb-10.10-
MDEV-25704and tested for mysql 8,0 compatibility. select random_bytes(0) is our extension. Note the fixme on TIME conversion in the test. Suggestions on implementing this much appreciated.