Details
-
Task
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
Description
Document all performance schema tables using per-column COMMENT, like in
--- a/storage/perfschema/table_file_instances.cc
|
+++ b/storage/perfschema/table_file_instances.cc
|
@@ -49,9 +49,9 @@ table_file_instances::m_share=
|
sizeof(PFS_simple_index),
|
&m_table_lock,
|
{ C_STRING_WITH_LEN("CREATE TABLE file_instances("
|
- "FILE_NAME VARCHAR(512) not null,"
|
- "EVENT_NAME VARCHAR(128) not null,"
|
- "OPEN_COUNT INTEGER unsigned not null)") },
|
+ "FILE_NAME VARCHAR(512) not null comment 'File name',"
|
+ "EVENT_NAME VARCHAR(128) not null comment 'Instrument name associated with the file',"
|
+ "OPEN_COUNT INTEGER unsigned not null comment 'Open handles on the file. A value of greater than zero means that the file is currently open')") },
|
false /* perpetual */
|
};
|
|
After that one can see the built-in documentation with
show create table performance_schema.file_instances |
or, better, with
select column_name, column_comment from information_schema.columns where table_schema='performance_schema' and table_name='file_instances' |
returning
+-------------+----------------------------------------------------------------------------------------------+
|
| column_name | column_comment |
|
+-------------+----------------------------------------------------------------------------------------------+
|
| FILE_NAME | File name |
|
| EVENT_NAME | Instrument name associated with the file |
|
| OPEN_COUNT | Open handles on the file. A value of greater than zero means that the file is currently open |
|
+-------------+----------------------------------------------------------------------------------------------+
|
The documentation text is taken from https://mariadb.com/kb/en/performance-schema-file_instances-table/
Attachments
Activity
Field | Original Value | New Value |
---|---|---|
Assignee | Vicențiu Ciorbaru [ cvicentiu ] |
Fix Version/s | 10.7 [ 24805 ] |
Priority | Major [ 3 ] | Critical [ 2 ] |
Fix Version/s | 10.2.41 [ 26032 ] | |
Fix Version/s | 10.3.32 [ 26029 ] | |
Fix Version/s | 10.4.22 [ 26031 ] | |
Fix Version/s | 10.5.13 [ 26026 ] | |
Fix Version/s | 10.6.5 [ 26034 ] | |
Fix Version/s | 10.7.1 [ 26120 ] | |
Fix Version/s | 10.7 [ 24805 ] | |
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Workflow | MariaDB v3 [ 120699 ] | MariaDB v4 [ 134424 ] |
Hi Sergei,
I'd like to work on this, if that is ok. I've checked the page here on https://mariadb.com/kb/en/performance-schema-tables/ . I think I know what to do.
Haidong