[MDEV-25003] mtflush_service_io - workitem status is always SUCCESS even if pool flush fails - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Minor
Resolution: Won't Fix
Affects Version/s: 10.2(EOL)
Fix Version/s: N/A
Component/s: Storage Engine - InnoDB
Labels:
None

Description

/storage/innobase/buf/buf0mtflu.cc - mtflush_service_io() function
workitem status is always SUCCESS even if pool flush fails, probably “else” is missing

	case MT_WRK_WRITE:

		ut_a(work_item->wi_status == WRK_ITEM_SET);

		work_item->wi_status = WRK_ITEM_START;

		/* Process work item */

		if (0 == (n_flushed = buf_mtflu_flush_pool_instance(work_item))) {

			work_item->wi_status = WRK_ITEM_FAILED;  <--------

		work_item->wi_status = WRK_ITEM_SUCCESS;     <--------

		ib_wqueue_add(mtflush_io->wr_cq, work_item, work_item->rheap);

		break;

Attachments

Issue Links

relates to

MDEV-13444 assertion mtflush_io != NULL on exit with innodb-use-mtflush

Closed

MDEV-13690 Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads parameters and related code

Closed

MDEV-23855 InnoDB log checkpointing causes regression for write-heavy OLTP

Closed

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Yury Chaikou

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2021-02-26 18:34

Updated:: 2021-10-25 14:01

Resolved:: 2021-04-26 12:56

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.