Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13690

Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads parameters and related code

Details

    Attachments

      Issue Links

        Activity

          jplindst Jan Lindström (Inactive) added a comment - http://lists.askmonty.org/pipermail/commits/2017-September/011436.html

          greenman Can you update KB that from 10.2.9 these variables are deprecated and from 10.3.2 these variables are removed.

          jplindst Jan Lindström (Inactive) added a comment - greenman Can you update KB that from 10.2.9 these variables are deprecated and from 10.3.2 these variables are removed.

          greenman Can you update KB that from 10.2.9 these variables are deprecated and from 10.3.2 these variables are removed.

          jplindst Jan Lindström (Inactive) added a comment - greenman Can you update KB that from 10.2.9 these variables are deprecated and from 10.3.2 these variables are removed.
          greenman Ian Gilfillan added a comment -

          Done, https://mariadb.com/kb/en/the-mariadb-library/xtradbinnodb-server-system-variables/ has been updated, will add to version release notes as well.

          greenman Ian Gilfillan added a comment - Done, https://mariadb.com/kb/en/the-mariadb-library/xtradbinnodb-server-system-variables/ has been updated, will add to version release notes as well.

          Looks OK, but please apply also this:

          diff --git a/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff b/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff
          index 46d6d7b30a4..27cead59b58 100644
          --- a/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff
          +++ b/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff
          @@ -364,15 +364,6 @@
            VARIABLE_COMMENT	Maximum delay of user threads in micro-seconds
            NUMERIC_MIN_VALUE	0
            NUMERIC_MAX_VALUE	10000000
          -@@ -1636,7 +1636,7 @@
          - GLOBAL_VALUE_ORIGIN	COMPILE-TIME
          - DEFAULT_VALUE	8
          - VARIABLE_SCOPE	GLOBAL
          --VARIABLE_TYPE	BIGINT
          -+VARIABLE_TYPE	INT
          - VARIABLE_COMMENT	DEPRECATED. Number of multi-threaded flush threads
          - NUMERIC_MIN_VALUE	1
          - NUMERIC_MAX_VALUE	64
           @@ -1692,10 +1692,10 @@
            GLOBAL_VALUE_ORIGIN	COMPILE-TIME
            DEFAULT_VALUE	0
          

          marko Marko Mäkelä added a comment - Looks OK, but please apply also this: diff --git a/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff b/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff index 46d6d7b30a4..27cead59b58 100644 --- a/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff +++ b/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff @@ -364,15 +364,6 @@ VARIABLE_COMMENT Maximum delay of user threads in micro-seconds NUMERIC_MIN_VALUE 0 NUMERIC_MAX_VALUE 10000000 -@@ -1636,7 +1636,7 @@ - GLOBAL_VALUE_ORIGIN COMPILE-TIME - DEFAULT_VALUE 8 - VARIABLE_SCOPE GLOBAL --VARIABLE_TYPE BIGINT -+VARIABLE_TYPE INT - VARIABLE_COMMENT DEPRECATED. Number of multi-threaded flush threads - NUMERIC_MIN_VALUE 1 - NUMERIC_MAX_VALUE 64 @@ -1692,10 +1692,10 @@ GLOBAL_VALUE_ORIGIN COMPILE-TIME DEFAULT_VALUE 0

          commit 016c35a7f2f4a288542f5fcb0e182c05238398e6
          Author: Jan Lindström <jan.lindstrom@mariadb.com>
          Date: Fri Sep 1 18:33:46 2017 +0300

          MDEV-13690: Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads parameters and related code

          Users can use innodb-page-cleaners instead.

          jplindst Jan Lindström (Inactive) added a comment - commit 016c35a7f2f4a288542f5fcb0e182c05238398e6 Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Fri Sep 1 18:33:46 2017 +0300 MDEV-13690 : Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads parameters and related code Users can use innodb-page-cleaners instead.

          People

            jplindst Jan Lindström (Inactive)
            jplindst Jan Lindström (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.