[MDEV-24973] Performance schema duplicates rarely executed code for mutex operations - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5, 10.6
Fix Version/s: 10.6.0
Component/s: Performance Schema
Labels:
- performance
- performance_schema

Description

The PERFORMANCE_SCHEMA wrapper for mutex and rw-lock operations is causing a lot of unlikely code to be inlined in each invocation. The impact of this may have been emphasized in MariaDB 10.6, because InnoDB now uses the common implementation of mutexes and condition variables (~~MDEV-21452~~).

By default, we build with cmake -DPLUGIN_PERFSCHEMA enabled, but at runtime no instrumentation will be enabled. Similar to ~~MDEV-22721~~, we’d better avoid inlining the rarely executed code in order to reduce the code size and to improve the efficiency of the instruction cache.

Attachments

Issue Links

relates to

MDEV-21452 Use condition variables and normal mutexes instead of InnoDB os_event and mutex

Closed

MDEV-22721 Remove bloat caused by InnoDB logger class

Closed

MDEV-33181 Performance schema introduces many conditional branches even when disabled at runtime

Open

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2021-02-24 16:29

Updated:: 2024-01-04 14:01

Resolved:: 2021-03-02 12:40

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.