Roel Van de Paar added a comment - 2021-05-11 06:15 10.6.1 f8665314d4ba190679001b81bb7d9fd7a38fc0f6 (Debug) mysqld: /test/10.6_dbg/sql/field.cc:4417: virtual longlong Field_long::val_int(): Assertion `marked_for_read()' failed. 10.6.1 f8665314d4ba190679001b81bb7d9fd7a38fc0f6 (Debug) Core was generated by `/test/MD100521-mariadb-10.6.1-linux-x86_64-dbg/bin/mysqld --no-defaults --core-'. Program terminated with signal SIGABRT, Aborted. #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 [Current thread is 1 (Thread 0x146da8e3f700 (LWP 1126611))] (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x0000146dbdcc4859 in __GI_abort () at abort.c:79 #2 0x0000146dbdcc4729 in __assert_fail_base (fmt=0x146dbde5a588 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x559ba14cf6e4 "marked_for_read()", file=0x559ba14cf4cb "/test/10.6_dbg/sql/field.cc", line=4417, function=<optimized out>) at assert.c:92 #3 0x0000146dbdcd5f36 in __GI___assert_fail (assertion=assertion@entry=0x559ba14cf6e4 "marked_for_read()", file=file@entry=0x559ba14cf4cb "/test/10.6_dbg/sql/field.cc", line=line@entry=4417, function=function@entry=0x559ba14d0c68 "virtual longlong Field_long::val_int()") at assert.c:101 #4 0x0000559ba0945d08 in Field_long::val_int (this=0x146d60024df0) at /test/10.6_dbg/sql/field.cc:4417 #5 0x0000559ba09936e9 in Item_field::val_int (this=0x146d60026210) at /test/10.6_dbg/sql/item.cc:3261 #6 0x0000559ba0a12d6f in Item_func_plus::int_op (this=0x146d60026350) at /test/10.6_dbg/sql/item_func.cc:1114 #7 0x0000559ba0881c9e in Item_func_hybrid_field_type::val_int_from_int_op (this=<optimized out>) at /test/10.6_dbg/sql/item_func.h:858 #8 Type_handler_int_result::Item_func_hybrid_field_type_val_int (this=<optimized out>, item=<optimized out>) at /test/10.6_dbg/sql/sql_type.cc:5396 #9 0x0000559ba09dce98 in Item_func_hybrid_field_type::val_int (this=0x146d60026350) at /test/10.6_dbg/sql/sql_type.h:7431 #10 0x0000559ba09aa8f5 in Item::save_int_in_field (this=0x146d60026350, field=0x146d60024ec8, no_conversions=<optimized out>) at /test/10.6_dbg/sql/item.cc:6669 #11 0x0000559ba08848b2 in Type_handler_int_result::Item_save_in_field (this=<optimized out>, item=<optimized out>, field=<optimized out>, no_conversions=<optimized out>) at /test/10.6_dbg/sql/sql_type.cc:4342 #12 0x0000559ba0990921 in Item::save_in_field (this=0x146d60026350, field=0x146d60024ec8, no_conversions=<optimized out>) at /test/10.6_dbg/sql/item.cc:6679 #13 0x0000559ba093edea in Field::set_default (this=0x146d60024ec8) at /test/10.6_dbg/sql/field.cc:2592 #14 0x0000559ba0961a3d in Field::save_in_field_default_value (this=0x146d60024ec8, view_error_processing=view_error_processing@entry=false) at /test/10.6_dbg/sql/field.cc:11240 #15 0x0000559ba0901b31 in Item_default_specification::save_in_field (this=<optimized out>, field_arg=<optimized out>) at /test/10.6_dbg/sql/item.h:6595 #16 0x0000559ba06203fd in fill_record (thd=thd@entry=0x146d60000db8, table_arg=table_arg@entry=0x146d6001f008, fields=@0x146d60005a88: {<base_list> = {<Sql_alloc> = {<No data fields>}, first = 0x146d60014970, last = 0x146d60014970, elements = 1}, <No data fields>}, values=@0x146d60006020: {<base_list> = {<Sql_alloc> = {<No data fields>}, first = 0x146d60014980, last = 0x146d60014980, elements = 1}, <No data fields>}, ignore_errors=ignore_errors@entry=false, update=update@entry=true) at /test/10.6_dbg/sql/sql_base.cc:8549 #17 0x0000559ba0620571 in fill_record_n_invoke_before_triggers (thd=thd@entry=0x146d60000db8, table=table@entry=0x146d6001f008, fields=@0x146d60005a88: {<base_list> = {<Sql_alloc> = {<No data fields>}, first = 0x146d60014970, last = 0x146d60014970, elements = 1}, <No data fields>}, values=@0x146d60006020: {<base_list> = {<Sql_alloc> = {<No data fields>}, first = 0x146d60014980, last = 0x146d60014980, elements = 1}, <No data fields>}, ignore_errors=ignore_errors@entry=false, event=event@entry=TRG_EVENT_UPDATE) at /test/10.6_dbg/sql/sql_base.cc:8727 #18 0x0000559ba07a7701 in mysql_update (thd=thd@entry=0x146d60000db8, table_list=<optimized out>, fields=@0x146d60005a88: {<base_list> = {<Sql_alloc> = {<No data fields>}, first = 0x146d60014970, last = 0x146d60014970, elements = 1}, <No data fields>}, values=@0x146d60006020: {<base_list> = {<Sql_alloc> = {<No data fields>}, first = 0x146d60014980, last = 0x146d60014980, elements = 1}, <No data fields>}, conds=<optimized out>, order_num=<optimized out>, order=<optimized out>, limit=18446744073709551615, ignore=false, found_return=0x146da8e3df10, updated_return=0x146da8e3e000) at /test/10.6_dbg/sql/sql_update.cc:1012 #19 0x0000559ba06ac2b7 in mysql_execute_command (thd=thd@entry=0x146d60000db8) at /test/10.6_dbg/sql/sql_limit.h:83 #20 0x0000559ba069702b in mysql_parse (thd=thd@entry=0x146d60000db8, rawbuf=<optimized out>, length=<optimized out>, parser_state=parser_state@entry=0x146da8e3e410) at /test/10.6_dbg/sql/sql_parse.cc:8018 #21 0x0000559ba06a5e5d in dispatch_command (command=command@entry=COM_QUERY, thd=thd@entry=0x146d60000db8, packet=packet@entry=0x146d6000b799 "UPDATE t SET b=DEFAULT", packet_length=packet_length@entry=22, blocking=blocking@entry=true) at /test/10.6_dbg/sql/sql_class.h:1333 #22 0x0000559ba06a9250 in do_command (thd=0x146d60000db8, blocking=blocking@entry=true) at /test/10.6_dbg/sql/sql_parse.cc:1406 #23 0x0000559ba0803dec in do_handle_one_connection (connect=<optimized out>, connect@entry=0x559ba2fa6a58, put_in_cache=put_in_cache@entry=true) at /test/10.6_dbg/sql/sql_connect.cc:1410 #24 0x0000559ba08043f1 in handle_one_connection (arg=arg@entry=0x559ba2fa6a58) at /test/10.6_dbg/sql/sql_connect.cc:1312 #25 0x0000559ba0cb6cee in pfs_spawn_thread (arg=0x559ba2e8dab8) at /test/10.6_dbg/storage/perfschema/pfs.cc:2201 #26 0x0000146dbe1d2609 in start_thread (arg=<optimized out>) at pthread_create.c:477 #27 0x0000146dbddc1293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Nikita Malyavin added a comment - 2021-06-26 17:20 b= DEFAULT(b) works fine. The problem is that we don't know which field's default value is calculated (hence nothing is done). We know this information when we are evaluating an expression because just item->save_in_field(field) is called, where Item is Item_default, or is an expression containing it. However, no such knoweledge in Item::fix_fields, where the read map is set up. To reduce the footprint fix_fields is left as is, and context resolution is made instead by transforming b= F(DEFAULT) -> b= F(DEFAULT(b)) . The patch for review is: 20982e2b903 on bb-10.2-nikita

Oleksandr Byelkin added a comment - 2021-06-28 13:48 OK to push

Nikita Malyavin added a comment - 2021-07-12 19:15 - edited The simple rewriting fails some tests, especially the following: UPDATE t1 set b= DEFAULT where b is a virtual column. Current behavior is to pass without a error, i.e. ignore it. However, b=DEFAULT(arg) would fail. The distinguishing was introduced in MDEV-22579 and though it is intended for INSERT, changing it in case of UPDATE (to report ER_WARNING_NON_DEFAULT_VALUE_FOR_GENERATED_COLUMN) can break workflows. The workaround is to distinguish DEFAULT transformed and DEFAULT(arg) for the case of error reporting New class Item_default_value_arg: public Item_default_value is introduced. bool vcol_assignment_allowed_value() is overriden New revision to review: https://github.com/MariaDB/server/commit/a1191b491b2257c4411188f2ae5ef3eeee10e2a8