Details
Blocker Description
Some developers apparently don't like that now my_vsnprintf("%.*s") behaves not as in the C standard.
So, we'll change it back and introduce %S to print the truncation indicator.
All %s that print something to the end user have to be changed, for example, to %S. This includes all error messages and everything in the code too.
Don't forget to update the documentation in the service header file.
And we'll need some way to ensure that in the future all new printfs to the use also use %S.
Attachments
Issue Links
- is caused by
-
MDEV-20604 Duplicate key value is silently truncated to 64 characters in print_keydup_error
-
- Closed
-
- relates to
-
MDEV-21978 make my_vsnprintf to use gcc-compatible format extensions
-
- Closed
-
-
-
- Closed
-
Activity
Maybe this can change, for example, to %sT , where T stands for truncated. And yes, the output will be different from whatever standard says, but it does not use either new unknown format specifiers, nor does it hijack the already known and documented ones, and it is still compatible with string, so you can use _attribute(format) on that.
yes, %sT, but that's after MDEV-21978. Depends on what's implemented first.
Sorry, I needed 2 after-merge fixes on 10.4. For the first one, my Windows build had failed without me noticing it, and that is why the %s→%T change was not reflected in the result file.
Please, do not use %S , this is confusing. %S It is there to print wide strings, i.e wchar_t *
Even on Linux, and it is documented.