Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.5
Description
While reviewing autobake-deb.sh I came across this commit:
https://github.com/MariaDB/server/commit/85bef794f7d7b61e9fc11f3d94e003c99a599b86
Adding a delete line in autobake-deb.sh seems odd. What was the motivation here? The git commit message is really short, there is no in-line comments and this is very confusing since all the TokuDB packaging is still there.
Do you serg want me to properly clean away all TokuDB packaging from debian/* ?
Attachments
Issue Links
- relates to
-
MDEV-19780 Remove the TokuDB storage engine
-
- Closed
-
Activity
Disabled in Debian packaging in https://github.com/MariaDB/server/commit/1589cf1cb3048984240f025ddc0c82fb311827fc
TokuDB packaging removed in https://github.com/MariaDB/server/commit/9cc1c74ca3391779d5f00ece09981d2932cf173b
I believe that yes, TokuDB should be removed from all packaging of MariaDB Server 10.5.
MDEV-19780gives reasons for removing the TokuDB from the MariaDB Server.I submitted a commit for removing TokuDB, but serg was conservative and preferred to preserve the source code in the branch, and only disable it at compilation time, so that it could be enabled if someone really needs it for some reason.
A similar decision was made with regard to the XtraDB storage engine in MariaDB Server 10.2. The XtraDB source code is present as ‘dead weight’ in the 10.2 branch, and it was finally removed in the 10.3 branch.