[MDEV-21944] Remove TokuDB from Debian packaging? Created: 2020-03-14 Updated: 2020-04-23 Resolved: 2020-04-23 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Packaging, Platform Debian |
| Affects Version/s: | 10.5 |
| Fix Version/s: | 10.5.3 |
| Type: | Bug | Priority: | Major |
| Reporter: | Otto Kekäläinen | Assignee: | Otto Kekäläinen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | TokuDB | ||
| Issue Links: |
|
||||||||
| Description |
|
While reviewing autobake-deb.sh I came across this commit: Adding a delete line in autobake-deb.sh seems odd. What was the motivation here? The git commit message is really short, there is no in-line comments and this is very confusing since all the TokuDB packaging is still there. Do you serg want me to properly clean away all TokuDB packaging from debian/* ? |
| Comments |
| Comment by Marko Mäkelä [ 2020-03-14 ] |
|
I believe that yes, TokuDB should be removed from all packaging of MariaDB Server 10.5.
I submitted a commit for removing TokuDB, but serg was conservative and preferred to preserve the source code in the branch, and only disable it at compilation time, so that it could be enabled if someone really needs it for some reason. A similar decision was made with regard to the XtraDB storage engine in MariaDB Server 10.2. The XtraDB source code is present as ‘dead weight’ in the 10.2 branch, and it was finally removed in the 10.3 branch. |
| Comment by Otto Kekäläinen [ 2020-04-05 ] |
|
Disabled in Debian packaging in https://github.com/MariaDB/server/commit/1589cf1cb3048984240f025ddc0c82fb311827fc |
| Comment by Otto Kekäläinen [ 2020-04-23 ] |
|
TokuDB packaging removed in https://github.com/MariaDB/server/commit/9cc1c74ca3391779d5f00ece09981d2932cf173b |