Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21751

innodb_fast_shutdown=0 can be unnecessarily slow

Details

    Description

      Now that MDEV-16264 replaced the InnoDB purge threads with tasks, it should be possible to increase the purge effort during a slow shutdown (while innodb_fast_shutdown=0 is in effect). Currently, we are using the fixed amount of innodb_purge_threads also during shutdown, even if the server were mostly idle.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26511 Innodb - do not allocate purge THDs during shutdown

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22577 innodb_fast_shutdown=0 fails to report purge progress

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-16260 Scale the purge effort according to the workload

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. MDEV-16264 Implement a common work queue for InnoDB background tasks

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26356 Performance regression after dict_sys.mutex removal

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            wlad Vladislav Vaintroub made changes -
            Affects Version/s 10.5 [ 23123 ]
            Issue Type Bug [ 1 ] Task [ 3 ]
            wlad Vladislav Vaintroub made changes -
            Assignee Vladislav Vaintroub [ wlad ] Julien Fritsch [ julien.fritsch ]
            julien.fritsch Julien Fritsch made changes -
            Assignee Julien Fritsch [ julien.fritsch ] Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]
            marko Marko Mäkelä made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] Marko Mäkelä [ marko ]
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Vladislav Vaintroub [ wlad ]
            wlad Vladislav Vaintroub made changes -
            issue.field.resolutiondate 2020-06-03 14:51:50.0 2020-06-03 14:51:50.428
            wlad Vladislav Vaintroub made changes -
            Fix Version/s 10.5.4 [ 24264 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Confirmed [ 10101 ] Closed [ 6 ]
            danblack Daniel Black added a comment -

            Thank you wlad

            danblack Daniel Black added a comment - Thank you wlad
            wlad Vladislav Vaintroub added a comment -

            Apparently, increasing threads did not seem to help much due to contention on the dictionary mutex, but maybe this will help in the future

            wlad Vladislav Vaintroub added a comment - Apparently, increasing threads did not seem to help much due to contention on the dictionary mutex, but maybe this will help in the future
            wlad Vladislav Vaintroub made changes -
            marko Marko Mäkelä added a comment -

            The dict_sys.mutex would be removed in MDEV-24258. That should allow concurrent execution of table lookup in multiple threads, such as those executing purge worker tasks.

            marko Marko Mäkelä added a comment - The dict_sys.mutex would be removed in MDEV-24258 . That should allow concurrent execution of table lookup in multiple threads, such as those executing purge worker tasks.
            marko Marko Mäkelä added a comment -

            It looks like MDEV-24258 may cause increased lower-level conflicts between purge workers, because dict_sys.mutex will no longer act as a ‘concurrency throttle’. Some performance regressions were observed before configuring innodb_purge_threads=1.

            marko Marko Mäkelä added a comment - It looks like MDEV-24258 may cause increased lower-level conflicts between purge workers, because dict_sys.mutex will no longer act as a ‘concurrency throttle’. Some performance regressions were observed before configuring innodb_purge_threads=1 .
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 104022 ] MariaDB v4 [ 134187 ]
            marko Marko Mäkelä made changes -
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 145845

            People

              wlad Vladislav Vaintroub
              marko Marko Mäkelä
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.