Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21653

test binaries my_safe_process and wsrep_check_version installed in library directory

Details

    • Bug
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 10.4.12
    • 10.5
    • Packaging, Tests
    • None

    Description

      While updating MariaDB 10.4.12 to Debian (after doing 10.4.6 in the summer) I came across this Lintian error (which did not yet exist in 10.4.6):

      E: mariadb-test: arch-dependent-file-in-usr-share usr/share/mysql/mysql-test/lib/My/SafeProcess/wsrep_check_version

      Why is this program installed in a library directory? Why not install it in /usr/bin/ as all the other MariaDB test binaries?

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21869 Make MariaDB 10.5 Lintian clean (Debian quality assurance tool)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Stalled
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21654 binary library file pam_mariadb_mtr.so installed among test data files

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • In Testing

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            otto Otto Kekäläinen added a comment -

            This still applies for MariaDB 10.11.6.

            otto Otto Kekäläinen added a comment - This still applies for MariaDB 10.11.6.
            illuusio Tuukka Pasanen added a comment -

            Is there some document what is correct location of libexec in Debian as should helper apps and scripts be in /usr/lib/<ARCH>/mariadb-test/My/SafeProcess/wsrep_check_version? But correct is that /usr/share is not the place for them.

            illuusio Tuukka Pasanen added a comment - Is there some document what is correct location of libexec in Debian as should helper apps and scripts be in /usr/lib/<ARCH>/mariadb-test/My/SafeProcess/wsrep_check_version? But correct is that /usr/share is not the place for them.
            danblack Daniel Black added a comment -

            Given mysql-test/lib/My/SafeProcess/wsrep_check_version.c is for checking v3 vs v4 provider and the v3 provider when EOL with MariaDB-10.3, can we just remove it? I assume the version check could just be in the server - wsrep-lib/src/server_state.cpp (however I don't see the equivalent lookup).

            danblack Daniel Black added a comment - Given mysql-test/lib/My/SafeProcess/wsrep_check_version.c is for checking v3 vs v4 provider and the v3 provider when EOL with MariaDB-10.3, can we just remove it? I assume the version check could just be in the server - wsrep-lib/src/server_state.cpp (however I don't see the equivalent lookup).
            illuusio Tuukka Pasanen added a comment -

            So any of current supported MariaDB versions should not have v3 provider when testing then with test package? Then I don't see reasoning why it should exist.

            illuusio Tuukka Pasanen added a comment - So any of current supported MariaDB versions should not have v3 provider when testing then with test package? Then I don't see reasoning why it should exist.
            illuusio Tuukka Pasanen added a comment -

            I've digged little bit and found that wsrep-lib/wsrep-API/v26/wsrep_loader.c has functions wsrep_check_version_symbol and wsrep_check_iface_version does the same what is done in mysql-test/lib/My/SafeProcess/wsrep_check_version.c so if about to keep it then it should be ported to use these library functions nor own implementation as then it should also test library functions to work.
            If I understand correctly wsrep_load uses wsrep_check_version_symbol to check this one. It can't be removed as it's used by sub wsrep_not_ok function in MTR but location can be tuned and I think also that it would use library function nor own implementation.

            illuusio Tuukka Pasanen added a comment - I've digged little bit and found that wsrep-lib/wsrep-API/v26/wsrep_loader.c has functions wsrep_check_version_symbol and wsrep_check_iface_version does the same what is done in mysql-test/lib/My/SafeProcess/wsrep_check_version.c so if about to keep it then it should be ported to use these library functions nor own implementation as then it should also test library functions to work. If I understand correctly wsrep_load uses wsrep_check_version_symbol to check this one. It can't be removed as it's used by sub wsrep_not_ok function in MTR but location can be tuned and I think also that it would use library function nor own implementation.

            People

              Unassigned Unassigned
              otto Otto Kekäläinen
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.