Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21654

binary library file pam_mariadb_mtr.so installed among test data files

Details

    • Bug
    • Status: In Testing (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 10.4.12
    • 10.4(EOL)
    • Packaging, Tests
    • None

    Description

      While updating MariaDB 10.4.12 to Debian (after doing 10.4.6 in the summer) I came across this Lintian error (which did not yet exist in 10.4.6):

      E: mariadb-test-data: arch-dependent-file-in-usr-share usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so
      		 
       E: mariadb-test-data: arch-independent-package-contains-binary-or-object usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so

      Why is this binary library file installed among test data files? Why not install it in the same directory as all other plugins, e.g. usr/lib/*/mariadb19/plugin/ ?

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21869 Make MariaDB 10.5 Lintian clean (Debian quality assurance tool)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Stalled
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29497 pam_mariadb_mtr.so packaged in mariadb-test-data arch-independent deb

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21653 test binaries my_safe_process and wsrep_check_version installed in library directory

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            serg Sergei Golubchik added a comment -

            Because it is not a plugin, it's a pam module for /lib/x86_64-linux-gnu/security (but a very lousy one with hard-coded passwords, so shouldn't be installed automatically)

            What do you suggest us to do? Where should it be installed?
            Alternatively, we can just not build it on Debian, if you'd like that.

            serg Sergei Golubchik added a comment - Because it is not a plugin, it's a pam module for /lib/x86_64-linux-gnu/security (but a very lousy one with hard-coded passwords, so shouldn't be installed automatically) What do you suggest us to do? Where should it be installed? Alternatively, we can just not build it on Debian, if you'd like that.
            otto Otto Kekäläinen added a comment - - edited

            Issue MDEV-21653 is basically identical. The requirement is that the package mariadb-test-data should not contain any arch specific files.

            How about installing this at /usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so ?

            Then it is easy to have in the mariadb-test package and not in the -data package.

            otto Otto Kekäläinen added a comment - - edited Issue MDEV-21653 is basically identical. The requirement is that the package mariadb-test-data should not contain any arch specific files. How about installing this at /usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so ? Then it is easy to have in the mariadb-test package and not in the -data package.
            otto Otto Kekäläinen added a comment -

            Daniel Black

            regarding pam_mariadb_mtr.so its neither a client connection plugin or a server plugin. Its a shared library used by pam itself. in /lib/security/ maybe based on https://packages.debian.org/buster/amd64/libpam-pkcs11/filelist . plugin/auth_pam/testing/mariadb_mtr.conf also needs to be installed (per within comments) for mtr to work with it.

            otto Otto Kekäläinen added a comment - Daniel Black regarding pam_mariadb_mtr.so its neither a client connection plugin or a server plugin. Its a shared library used by pam itself. in /lib/security/ maybe based on https://packages.debian.org/buster/amd64/libpam-pkcs11/filelist . plugin/auth_pam/testing/mariadb_mtr.conf also needs to be installed (per within comments) for mtr to work with it.
            otto Otto Kekäläinen added a comment -

            With the latest version of Lintian, the complaint about 10.5.10 is:

            arch-dependent-file-in-usr-share usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so
            		 
            arch-independent-package-contains-binary-or-object usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so
            		 
            missing-dependency-on-libc needed by usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so
            		 
            unstripped-binary-or-object usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so

            otto Otto Kekäläinen added a comment - With the latest version of Lintian, the complaint about 10.5.10 is: arch-dependent-file-in-usr-share usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so arch-independent-package-contains-binary-or-object usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so missing-dependency-on-libc needed by usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so unstripped-binary-or-object usr/share/mysql/mysql-test/suite/plugins/pam/pam_mariadb_mtr.so
            otto Otto Kekäläinen added a comment -

            With Debhelper version 13 this became a hard error/blocker in Debian, so I solved it for now by simply removing the file: https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/4abb5482ab1cdcd9659b8bf6da57b7c27233f7ef

            I can put it back if upstream changes to location to the same place where all other test plugins are.

            I don't see a strong reason to have all other test plugins in one place and just this one in a separate place.

            otto Otto Kekäläinen added a comment - With Debhelper version 13 this became a hard error/blocker in Debian, so I solved it for now by simply removing the file: https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/4abb5482ab1cdcd9659b8bf6da57b7c27233f7ef I can put it back if upstream changes to location to the same place where all other test plugins are. I don't see a strong reason to have all other test plugins in one place and just this one in a separate place.
            serg Sergei Golubchik added a comment -

            See my first comment, pam_mariadb_mtr.so is not a plugin, it's a pam module, like /lib/x86_64-linux-gnu/security/pam_unix.so, but it cannot be installed automatically, because it uses hard-coded passwords.

            Best is not to include it at all, indeed.

            serg Sergei Golubchik added a comment - See my first comment, pam_mariadb_mtr.so is not a plugin, it's a pam module, like /lib/x86_64-linux-gnu/security/pam_unix.so , but it cannot be installed automatically, because it uses hard-coded passwords. Best is not to include it at all, indeed.

            People

              serg Sergei Golubchik
              otto Otto Kekäläinen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.