Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21587

Regression since 10.1.44 release: test disks_notembedded fails in Ubuntu 18.04 (still affect 11.0)

Details

    Description

      While importing latest MariaDB 10.1.44 and doing test builds before upload to Ubuntu 18.04 I noticed all builds failed at https://launchpad.net/~mysql-ubuntu/+archive/ubuntu/mariadb-10.1/+builds?build_text=&build_state=all

      disks.disks_notembedded                  w1 [ fail ]
              Test ended at 2020-01-29 08:05:53
       
      CURRENT_TEST: disks.disks_notembedded
      --- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.result	2020-01-25 21:54:37.000000000 +0000
      +++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.reject	2020-01-29 08:05:52.909814219 +0000
      @@ -10,6 +10,6 @@
       GRANT FILE ON *.* TO user1@localhost;
       select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
       sum(Total) > sum(Available)	sum(Total)>sum(Used)
      -1	1
      +NULL	NULL
       DROP USER user1@localhost;
       # End of 10.1 tests
       
      mysqltest: Result length mismatch
      

      Full log at https://launchpadlibrarian.net/462586124/buildlog_ubuntu-bionic-amd64.mariadb-10.1_1%3A10.1.44-0ubuntu0.18.04.1~ubuntu18.04.1~1580282784.5039329b84_BUILDING.txt.gz

      Since exactly same failure happened on all platforms, it is certainly not a sporadic failure.

      I would either need a patch for this failure I can add on top of 10.1.44 sources (at https://salsa.debian.org/mariadb-team/mariadb-10.1/tree/ubuntu-18.04) or somebody to acknowledge that this error is safe to ignore.

      Attachments

        Issue Links

          Activity

            Almost the same issue still affects latest MariaDB. See log https://launchpadlibrarian.net/656676218/buildlog_ubuntu-lunar-amd64.mariadb_1%3A10.11.2-2~ubuntu23.04.1~1679260930.3d164ca5277.dev.otto_BUILDING.txt.gz

            disks.disks                              w3 [ fail ]
                    Test ended at 2023-03-19 22:24:41
             
            CURRENT_TEST: disks.disks
            --- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.result	2023-02-01 17:28:03.000000000 +0000
            +++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.reject	2023-03-19 22:24:40.957776210 +0000
            @@ -9,4 +9,4 @@
             ) ENGINE=MEMORY DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci
             select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
             sum(Total) > sum(Available)	sum(Total)>sum(Used)
            -1	1
            +0	1
             
             
            disks.disks_notembedded                  w3 [ fail ]
                    Test ended at 2023-03-19 22:24:41
             
            CURRENT_TEST: disks.disks_notembedded
            --- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.result	2023-02-01 17:28:03.000000000 +0000
            +++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.reject	2023-03-19 22:24:41.513783805 +0000
            @@ -16,7 +16,7 @@
             connection con1;
             select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
             sum(Total) > sum(Available)	sum(Total)>sum(Used)
            -1	1
            +0	1
             connection default;
             DROP USER user1@localhost;
             # End of 10.1 tests
             
            mysqltest: Result content mismatch
            

            otto Otto Kekäläinen added a comment - Almost the same issue still affects latest MariaDB. See log https://launchpadlibrarian.net/656676218/buildlog_ubuntu-lunar-amd64.mariadb_1%3A10.11.2-2~ubuntu23.04.1~1679260930.3d164ca5277.dev.otto_BUILDING.txt.gz disks.disks w3 [ fail ] Test ended at 2023-03-19 22:24:41   CURRENT_TEST: disks.disks --- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.result 2023-02-01 17:28:03.000000000 +0000 +++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.reject 2023-03-19 22:24:40.957776210 +0000 @@ -9,4 +9,4 @@ ) ENGINE=MEMORY DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks; sum(Total) > sum(Available) sum(Total)>sum(Used) -1 1 +0 1     disks.disks_notembedded w3 [ fail ] Test ended at 2023-03-19 22:24:41   CURRENT_TEST: disks.disks_notembedded --- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.result 2023-02-01 17:28:03.000000000 +0000 +++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.reject 2023-03-19 22:24:41.513783805 +0000 @@ -16,7 +16,7 @@ connection con1; select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks; sum(Total) > sum(Available) sum(Total)>sum(Used) -1 1 +0 1 connection default; DROP USER user1@localhost; # End of 10.1 tests   mysqltest: Result content mismatch
            danblack Daniel Black added a comment -

            Might be that Sum(Total) = sum(Available) because of very large values of Total and low values of Used.

            > -> >= might solve it.

            NULL would be no storage found. Implementation changes significantly in https://github.com/MariaDB/server/pull/2216 (MDEV-28592 / MDEV-27818) see commit details. Might be it cannot reasonably occur in ci situtations.

            danblack Daniel Black added a comment - Might be that Sum(Total) = sum(Available) because of very large values of Total and low values of Used. > -> >= might solve it. NULL would be no storage found. Implementation changes significantly in https://github.com/MariaDB/server/pull/2216 ( MDEV-28592 / MDEV-27818 ) see commit details. Might be it cannot reasonably occur in ci situtations.

            I just ran the full official test suite and these disk.disks and disk.disks_notembedded are still failing (log https://launchpadlibrarian.net/690458994/buildlog_ubuntu-mantic-amd64.mariadb_1%3A10.11.5-2~bpo23.10.1~1696482175.fcfd3a06fd5.debian.latest.full.mariadb.test.run_BUILDING.txt.gz)

            disks.disks                              w1 [ fail ]
                    Test ended at 2023-10-05 06:01:49
             
            CURRENT_TEST: disks.disks
            --- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.result	2023-08-11 06:35:40.000000000 +0000
            +++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.reject	2023-10-05 06:01:49.380731316 +0000
            @@ -9,4 +9,4 @@
             ) ENGINE=MEMORY DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci
             select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
             sum(Total) > sum(Available)	sum(Total)>sum(Used)
            -1	1
            +0	1
             
            mysqltest: Result content mismatch
            

            otto Otto Kekäläinen added a comment - I just ran the full official test suite and these disk.disks and disk.disks_notembedded are still failing (log https://launchpadlibrarian.net/690458994/buildlog_ubuntu-mantic-amd64.mariadb_1%3A10.11.5-2~bpo23.10.1~1696482175.fcfd3a06fd5.debian.latest.full.mariadb.test.run_BUILDING.txt.gz ) disks.disks w1 [ fail ] Test ended at 2023-10-05 06:01:49   CURRENT_TEST: disks.disks --- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.result 2023-08-11 06:35:40.000000000 +0000 +++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.reject 2023-10-05 06:01:49.380731316 +0000 @@ -9,4 +9,4 @@ ) ENGINE=MEMORY DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks; sum(Total) > sum(Available) sum(Total)>sum(Used) -1 1 +0 1   mysqltest: Result content mismatch
            danblack Daniel Black added a comment -

            for large values of storage, available=total due to rounding. Need to change the test to:

             sum(Total) >= sum(Available)	
            

            danblack Daniel Black added a comment - for large values of storage, available=total due to rounding. Need to change the test to: sum(Total) >= sum(Available)

            I can confirm that disks.disks is now fixed thanks to https://github.com/MariaDB/server/pull/2777, but not yet disks.disks_notembedded.

            otto Otto Kekäläinen added a comment - I can confirm that disks.disks is now fixed thanks to https://github.com/MariaDB/server/pull/2777 , but not yet disks.disks_notembedded .

            People

              danblack Daniel Black
              otto Otto Kekäläinen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.