Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20832

Don't print "row size too large" warnings in error log if innodb_strict_mode=OFF and log_warnings<=2

Details

    Description

      If a user executes DDL that effects a table which has too large rows, then the error log will contain a message like the following:

      2019-07-28  0:57:51 140189814937344 [Warning] InnoDB: Cannot add field `c08` in table `test`.`t1` because after adding it, the row size is 2484 which is greater than maximum allowed size (1982) for a record on index leaf page.

      (I believe the specific message may change in the patch for MDEV-20194.)

      With the default value of innodb_strict_mode=ON, it will be an error. If the user sets innodb_strict_mode=OFF, then it will be a warning.

      https://mariadb.com/kb/en/library/troubleshooting-row-size-too-large-errors-with-innodb/

      Some users think that it should be possible to suppress this warning in the error log if the user sets innodb_strict_mode=OFF.

      By default, log_warnings is set to 2.

      https://mariadb.com/kb/en/library/server-system-variables/#log_warnings

      Maybe this warning should only be printed when innodb_strict_mode=OFF if log_warnings > 2, so that it doesn't get printed to the error log by default.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21261 When performing instant add column, InnoDB ignores innodb_strict_mode for "row size too large" check

          • Major - Major loss of function.
          • Confirmed

          Task - A task that needs to be done. MDEV-16969 Fix error message as promised in upstream Bug #69336

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-19292 "Row size too large" error when creating table with lots columns when row format is DYNAMIC or COMPRESSED

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20194 Warnings inconsistently issued upon CHECK on table from older versions

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-20400 Implement a way to query an InnoDB table max row size

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20786 MariaDB server writes warnings into errorlog although 'log_warnings=0'

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20949 Stop performing unnecessary maximum row size check for DML

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22585 Incorrect note being written to the error log when CREATE and ALTER fail due to Row Size Too Large and in all cases for TRUNCATE and OPTIMIZE TABLE.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. MDEV-23521 Implement an InnoDB row format that can use overflow pages for smaller columns

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            GeoffMontee Geoff Montee (Inactive) created issue -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Field Original Value New Value
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            alice Alice Sherepa made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Summary Don't print "row size too large" warnings in error log if innodb_strict_mode=OFF and log_warnings=2 Don't print "row size too large" warnings in error log if innodb_strict_mode=OFF and log_warnings<=2
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            kevg Eugene Kosov (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            kevg Eugene Kosov (Inactive) made changes -
            Assignee Eugene Kosov [ kevg ] Thirunarayanan Balathandayuthapani [ thiru ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            GeoffMontee Geoff Montee (Inactive) made changes -
            kevg Eugene Kosov (Inactive) made changes -
            issue.field.resolutiondate 2019-11-20 13:09:51.0 2019-11-20 13:09:51.58
            kevg Eugene Kosov (Inactive) made changes -
            Fix Version/s 10.2.30 [ 24015 ]
            Fix Version/s 10.3.21 [ 24014 ]
            Fix Version/s 10.4.11 [ 24013 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Assignee Thirunarayanan Balathandayuthapani [ thiru ] Eugene Kosov [ kevg ]
            Resolution Fixed [ 1 ]
            Status In Review [ 10002 ] Closed [ 6 ]
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 100421 ] MariaDB v4 [ 156865 ]
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 147879 113644 118409 185863 160501 150204 114072 195104 198426 164062 166795 159353

            People

              kevg Eugene Kosov (Inactive)
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.