[MDEV-20832] Don't print "row size too large" warnings in error log if innodb_strict_mode=OFF and log_warnings<=2 Created: 2019-10-15  Updated: 2020-08-25  Resolved: 2019-11-20

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.2.27, 10.3.18, 10.4.8
Fix Version/s: 10.2.30, 10.3.21, 10.4.11

Type: Bug Priority: Major
Reporter: Geoff Montee (Inactive) Assignee: Eugene Kosov (Inactive)
Resolution: Fixed Votes: 1
Labels: None

Issue Links:
Relates
relates to MDEV-21261 When performing instant add column, I... Confirmed
relates to MDEV-16969 Fix error message as promised in upst... Open
relates to MDEV-19292 "Row size too large" error when creat... Closed
relates to MDEV-20194 Warnings inconsistently issued upon C... Closed
relates to MDEV-20400 Implement a way to query an InnoDB ta... Confirmed
relates to MDEV-20786 MariaDB server writes warnings into e... Closed
relates to MDEV-20949 Stop performing unnecessary maximum r... Closed
relates to MDEV-22585 Incorrect note being written to the e... Open
relates to MDEV-23521 Implement an InnoDB row format that c... Open

 Description   

If a user executes DDL that effects a table which has too large rows, then the error log will contain a message like the following:

2019-07-28  0:57:51 140189814937344 [Warning] InnoDB: Cannot add field `c08` in table `test`.`t1` because after adding it, the row size is 2484 which is greater than maximum allowed size (1982) for a record on index leaf page.

(I believe the specific message may change in the patch for MDEV-20194.)

With the default value of innodb_strict_mode=ON, it will be an error. If the user sets innodb_strict_mode=OFF, then it will be a warning.

https://mariadb.com/kb/en/library/troubleshooting-row-size-too-large-errors-with-innodb/

Some users think that it should be possible to suppress this warning in the error log if the user sets innodb_strict_mode=OFF.

By default, log_warnings is set to 2.

https://mariadb.com/kb/en/library/server-system-variables/#log_warnings

Maybe this warning should only be printed when innodb_strict_mode=OFF if log_warnings > 2, so that it doesn't get printed to the error log by default.


Generated at Thu Feb 08 09:02:30 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.