Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20832

Don't print "row size too large" warnings in error log if innodb_strict_mode=OFF and log_warnings<=2

    XMLWordPrintable

    Details

      Description

      If a user executes DDL that effects a table which has too large rows, then the error log will contain a message like the following:

      2019-07-28  0:57:51 140189814937344 [Warning] InnoDB: Cannot add field `c08` in table `test`.`t1` because after adding it, the row size is 2484 which is greater than maximum allowed size (1982) for a record on index leaf page.
      

      (I believe the specific message may change in the patch for MDEV-20194.)

      With the default value of innodb_strict_mode=ON, it will be an error. If the user sets innodb_strict_mode=OFF, then it will be a warning.

      https://mariadb.com/kb/en/library/troubleshooting-row-size-too-large-errors-with-innodb/

      Some users think that it should be possible to suppress this warning in the error log if the user sets innodb_strict_mode=OFF.

      By default, log_warnings is set to 2.

      https://mariadb.com/kb/en/library/server-system-variables/#log_warnings

      Maybe this warning should only be printed when innodb_strict_mode=OFF if log_warnings > 2, so that it doesn't get printed to the error log by default.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              kevg Eugene Kosov
              Reporter:
              GeoffMontee Geoff Montee
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: