Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20428

"Start binlog_dump" message doesn't indicate GTID position

Details

    Description

      The "Start binlog_dump" message hasn't been updated to include the slave's requested GTID position:

      2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4)

      See here:

      https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2111

      For diagnostic purposes, I think it would be helpful if the GTID position were included. For example, maybe the message could be updated to something like this:

      2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4), using_gtid(1), gtid('1-1-201,2-2-100')
      		 
      2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(3), pos('mariadb-bin.004142', 507988273), using_gtid(0), gtid('')

      I do see that the GTID position is available in the connect_gtid_state variable:

      https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2091

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-8169 Error log binlog_dump message does not work correctly with GTID

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            GeoffMontee Geoff Montee (Inactive) created issue -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Field Original Value New Value
            Labels gtid logging replication
            GeoffMontee Geoff Montee (Inactive) made changes -
            Description The "Start binlog_dump" message hasn't been updated to include the slave's requested GTID position:

            {noformat}
            2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4)
            {noformat}

            See here:

            https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2111             		The "Start binlog_dump" message hasn't been updated to include the slave's requested GTID position:

            {noformat}
            2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4)
            {noformat}

            See here:

            https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2111

            For diagnostic purposes, I think it would be helpful if the GTID position were included. For example, maybe the message could be updated to something like this:

            {noformat}
            2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4), using_gtid(1), gtid('1-1-201,2-2-100')
            2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(3), pos('mariadb-bin.004142', 507988273), using_gtid(0), gtid('')
            {noformat}

            I do see that the GTID position is available in the connect_gtid_state variable:

            https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2091
            Elkin Andrei Elkin made changes -
            Assignee Andrei Elkin [ elkin ] Sujatha Sivakumar [ sujatha.sivakumar ]
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            Status Confirmed [ 10101 ] In Progress [ 3 ]
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Hello Andrei,

            Please review the changes for MDEV-20428.

            https://github.com/MariaDB/server/commit/64703f4de57f619e158e9523e45691eda0da6c33
            Build Bot:http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.1-sujatha

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Hello Andrei, Please review the changes for MDEV-20428 . https://github.com/MariaDB/server/commit/64703f4de57f619e158e9523e45691eda0da6c33 Build Bot: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.1-sujatha
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            Assignee Sujatha Sivakumar [ sujatha.sivakumar ] Andrei Elkin [ elkin ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            Elkin Andrei Elkin added a comment -

            The patch looks pretty good.
            Thanks!

            Elkin Andrei Elkin added a comment - The patch looks pretty good. Thanks!
            Elkin Andrei Elkin made changes -
            Assignee Andrei Elkin [ elkin ] Sujatha Sivakumar [ sujatha.sivakumar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Fix is pushed into 10.1.46. Cherry-picked the 10.1 changes to higher versions. Tested them.

            10.2 Patch is slightly different from 10.1.
            Minor changes are required to test. Please find the following patch.
            10.2: https://github.com/MariaDB/server/commit/4bcd982186b90eec02dec35205a7a52b4ddf29d2

            The patch remains the same from 10.2+ onwards.
            10.3: https://github.com/MariaDB/server/commit/d2f89c827b79a85dc0cd8c80278d0981d906f895
            10.4: https://github.com/MariaDB/server/commit/e4f3fe2282f21de3bee0f77aa02de324e92a5660
            10.5: https://github.com/MariaDB/server/commit/9ea8a2ead69e12a69f3a07dbc29f83fd7a0449a4

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Fix is pushed into 10.1.46. Cherry-picked the 10.1 changes to higher versions. Tested them. 10.2 Patch is slightly different from 10.1. Minor changes are required to test. Please find the following patch. 10.2: https://github.com/MariaDB/server/commit/4bcd982186b90eec02dec35205a7a52b4ddf29d2 The patch remains the same from 10.2+ onwards. 10.3: https://github.com/MariaDB/server/commit/d2f89c827b79a85dc0cd8c80278d0981d906f895 10.4: https://github.com/MariaDB/server/commit/e4f3fe2282f21de3bee0f77aa02de324e92a5660 10.5: https://github.com/MariaDB/server/commit/9ea8a2ead69e12a69f3a07dbc29f83fd7a0449a4
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            issue.field.resolutiondate 2020-06-16 05:44:53.0 2020-06-16 05:44:53.891
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            Fix Version/s 10.5.4 [ 24264 ]
            Fix Version/s 10.1.46 [ 24308 ]
            Fix Version/s 10.2.33 [ 24307 ]
            Fix Version/s 10.3.24 [ 24306 ]
            Fix Version/s 10.4.14 [ 24305 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.5.5 [ 24423 ]
            Fix Version/s 10.5.4 [ 24264 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 99237 ] MariaDB v4 [ 156674 ]
            bnestere Brandon Nesterenko made changes -
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 134539 170252

            People

              sujatha.sivakumar Sujatha Sivakumar (Inactive)
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.