Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20428

"Start binlog_dump" message doesn't indicate GTID position

    XMLWordPrintable

    Details

      Description

      The "Start binlog_dump" message hasn't been updated to include the slave's requested GTID position:

      2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4)
      

      See here:

      https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2111

      For diagnostic purposes, I think it would be helpful if the GTID position were included. For example, maybe the message could be updated to something like this:

      2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4), using_gtid(1), gtid('1-1-201,2-2-100')
      2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(3), pos('mariadb-bin.004142', 507988273), using_gtid(0), gtid('')
      

      I do see that the GTID position is available in the connect_gtid_state variable:

      https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2091

        Attachments

          Activity

            People

            Assignee:
            sujatha.sivakumar Sujatha Sivakumar
            Reporter:
            GeoffMontee Geoff Montee
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: