[MDEV-20428] "Start binlog_dump" message doesn't indicate GTID position Created: 2019-08-26  Updated: 2020-08-25  Resolved: 2020-06-16

Status: Closed
Project: MariaDB Server
Component/s: Replication
Affects Version/s: 10.2.26, 10.1.41, 10.3.17, 10.4.7
Fix Version/s: 10.1.46, 10.2.33, 10.3.24, 10.4.14, 10.5.5

Type: Bug Priority: Major
Reporter: Geoff Montee (Inactive) Assignee: Sujatha Sivakumar (Inactive)
Resolution: Fixed Votes: 0
Labels: gtid, logging, replication


 Description   

The "Start binlog_dump" message hasn't been updated to include the slave's requested GTID position:

2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4)

See here:

https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2111

For diagnostic purposes, I think it would be helpful if the GTID position were included. For example, maybe the message could be updated to something like this:

2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(2), pos(, 4), using_gtid(1), gtid('1-1-201,2-2-100')
 
2019-08-25 20:05:05 139836760311552 [Note] Start binlog_dump to slave_server(3), pos('mariadb-bin.004142', 507988273), using_gtid(0), gtid('')

I do see that the GTID position is available in the connect_gtid_state variable:

https://github.com/MariaDB/server/blob/mariadb-10.4.7/sql/sql_repl.cc#L2091

 Comments   
Comment by Sujatha Sivakumar (Inactive) [ 2020-06-11 ]

Hello Andrei,

Please review the changes for MDEV-20428.

https://github.com/MariaDB/server/commit/64703f4de57f619e158e9523e45691eda0da6c33
Build Bot:http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.1-sujatha

Comment by Andrei Elkin [ 2020-06-11 ]

The patch looks pretty good.
Thanks!

Comment by Sujatha Sivakumar (Inactive) [ 2020-06-16 ]

Fix is pushed into 10.1.46. Cherry-picked the 10.1 changes to higher versions. Tested them.

10.2 Patch is slightly different from 10.1.
Minor changes are required to test. Please find the following patch.
10.2: https://github.com/MariaDB/server/commit/4bcd982186b90eec02dec35205a7a52b4ddf29d2

The patch remains the same from 10.2+ onwards.
10.3: https://github.com/MariaDB/server/commit/d2f89c827b79a85dc0cd8c80278d0981d906f895
10.4: https://github.com/MariaDB/server/commit/e4f3fe2282f21de3bee0f77aa02de324e92a5660
10.5: https://github.com/MariaDB/server/commit/9ea8a2ead69e12a69f3a07dbc29f83fd7a0449a4

Generated at Thu Feb 08 08:59:24 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.