Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20185

Windows : Use of uninitialized value $bpath in string eq at .../mysql-test-run.pl line 518.

Details

    Description

      mtr is broken after https://github.com/MariaDB/server/commit/f5390eea9a9f

      Every invocation on Windows now produces

      Use of uninitialized value $bpath in string eq at C:/work/10.4/mysql-test/mysql-test-run.pl line 518.
      		 
      Collecting tests...
      		 
      Use of uninitialized value $mariabackup_path in string ne at C:/work/10.4/mysql-test/mysql-test-run.pl line 389.
      		 
      'sh' is not recognized as an internal or external command,
      		 
      operable program or batch file.
      		 
      Use of uninitialized value $mariabackup_path in string ne at C:/work/10.4/mysql-test/mysql-test-run.pl line 389.

      mtr does not rely on sh (use of "sh"), and other things like have_mariabackup.inc handling raises an eyebrow (now it needs ss, and nc, and what not, why?)

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18565 Galera mtr-suite fails if galera library is not installed

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            sysprg Julius Goryavsky added a comment - - edited

            The execution of mtr in the Windows environment fails due to the fact that the new code from MDEV-18565 does not take into account the need to add the ".exe" extension to the names of
            executable files when searching for pre-requisites that are needed to run SST scripts (especially when using mariabackup) and when searching paths to some other Galera utilities. This patch fixes this flaw.

            Also adding paths to the PATH environment variable is now done with the correct delimiter character.

            https://github.com/MariaDB/server/commit/2950ab94b7323a69b948e784af64cb25e1ca2f27

            sysprg Julius Goryavsky added a comment - - edited The execution of mtr in the Windows environment fails due to the fact that the new code from MDEV-18565 does not take into account the need to add the ".exe" extension to the names of executable files when searching for pre-requisites that are needed to run SST scripts (especially when using mariabackup) and when searching paths to some other Galera utilities. This patch fixes this flaw. Also adding paths to the PATH environment variable is now done with the correct delimiter character. https://github.com/MariaDB/server/commit/2950ab94b7323a69b948e784af64cb25e1ca2f27
            jplindst Jan Lindström (Inactive) added a comment -

            ok to push.

            jplindst Jan Lindström (Inactive) added a comment - ok to push.
            sysprg Julius Goryavsky added a comment -

            After review and testing, the correction is applied to 10.2, 10.3 and 10.4 branches

            sysprg Julius Goryavsky added a comment - After review and testing, the correction is applied to 10.2, 10.3 and 10.4 branches

            People

              sysprg Julius Goryavsky
              wlad Vladislav Vaintroub
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.