[MDEV-20185] Windows : Use of uninitialized value $bpath in string eq at .../mysql-test-run.pl line 518. Created: 2019-07-26  Updated: 2019-08-19  Resolved: 2019-08-19

Status: Closed
Project: MariaDB Server
Component/s: Tests
Affects Version/s: 10.4
Fix Version/s: 10.2.27, 10.3.18, 10.4.8

Type: Bug Priority: Major
Reporter: Vladislav Vaintroub Assignee: Julius Goryavsky
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Problem/Incident
is caused by MDEV-18565 Galera mtr-suite fails if galera libr... Closed

 Description   

mtr is broken after https://github.com/MariaDB/server/commit/f5390eea9a9f

Every invocation on Windows now produces

Use of uninitialized value $bpath in string eq at C:/work/10.4/mysql-test/mysql-test-run.pl line 518.
 
Collecting tests...
 
Use of uninitialized value $mariabackup_path in string ne at C:/work/10.4/mysql-test/mysql-test-run.pl line 389.
 
'sh' is not recognized as an internal or external command,
 
operable program or batch file.
 
Use of uninitialized value $mariabackup_path in string ne at C:/work/10.4/mysql-test/mysql-test-run.pl line 389.

mtr does not rely on sh (use of "sh"), and other things like have_mariabackup.inc handling raises an eyebrow (now it needs ss, and nc, and what not, why?)

 Comments   
Comment by Julius Goryavsky [ 2019-07-30 ]

The execution of mtr in the Windows environment fails due to the fact that the new code from MDEV-18565 does not take into account the need to add the ".exe" extension to the names of
executable files when searching for pre-requisites that are needed to run SST scripts (especially when using mariabackup) and when searching paths to some other Galera utilities. This patch fixes this flaw.

Also adding paths to the PATH environment variable is now done with the correct delimiter character.

https://github.com/MariaDB/server/commit/2950ab94b7323a69b948e784af64cb25e1ca2f27

Comment by Jan Lindström (Inactive) [ 2019-08-12 ]

ok to push.

Comment by Julius Goryavsky [ 2019-08-19 ]

After review and testing, the correction is applied to 10.2, 10.3 and 10.4 branches

Generated at Thu Feb 08 08:57:29 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.