Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20006

Move geometry specific code in Field_blob::get_key_image() to Field_geom

Details

    Description

      The code in field.cc

      uint Field_blob::get_key_image(uchar *buff,uint length, imagetype type_arg)
      {
      #ifdef HAVE_SPATIAL
        if (type_arg == itMBR)
        {
          // handle spatial key
          return ...;
        }
      #endif
        // handle scalar key
        return ...;
      }
      

      To turn GIS implementation into a data type plugin, let's do the following:

      • move this code from Field_blob to Field_geom.
      • move these dependencoes from item.h to item_geofunc.h:

        #include "gstream.h"
        #include "spatial.h"
        

      Attachments

        Issue Links

          Activity

            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Rank Ranked higher
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2019-07-10 05:04:29.0 2019-07-10 05:04:29.961
            bar Alexander Barkov made changes -
            Component/s Data types [ 13906 ]
            Component/s GIS [ 10105 ]
            Fix Version/s 10.5.0 [ 23709 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 98126 ] MariaDB v4 [ 134037 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.