[MDEV-20006] Move geometry specific code in Field_blob::get_key_image() to Field_geom Created: 2019-07-10  Updated: 2019-07-10  Resolved: 2019-07-10

Status: Closed
Project: MariaDB Server
Component/s: Data types, GIS
Fix Version/s: 10.5.0

Type: Task Priority: Major
Reporter: Alexander Barkov Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDEV-4912 Data type plugin API version 1 Closed

 Description   

The code in field.cc

uint Field_blob::get_key_image(uchar *buff,uint length, imagetype type_arg)
 
{
 
#ifdef HAVE_SPATIAL
 
  if (type_arg == itMBR)
 
  {
 
    // handle spatial key
 
    return ...;
 
  }
 
#endif
 
  // handle scalar key
 
  return ...;
 
}

To turn GIS implementation into a data type plugin, let's do the following:

  • move this code from Field_blob to Field_geom.
  • move these dependencoes from item.h to item_geofunc.h: 

    #include "gstream.h"
    		 
    #include "spatial.h"


Generated at Thu Feb 08 08:56:01 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.