Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19851

server_audit plugin should not allow server_audit_output_type=SYSLOG on Windows

Details

    Description

      Windows does not have syslog, so the server_audit plugin does not try to build syslog support on Windows. Instead, it just defines the syslog-related functions as noops on Windows:

      https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L25

      server_audit_output_type=SYSLOG can still be set on Windows:

      https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L389

      https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L2740

      Since the syslog functions are defined as noops on Windows, this output type will not do anything.

      It seems like it would be better to not allow server_audit_output_type=SYSLOG on Windows.

      Attachments

        Activity

          GeoffMontee Geoff Montee (Inactive) created issue -
          holyfoot Alexey Botchkov made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          holyfoot Alexey Botchkov made changes -
          issue.field.resolutiondate 2019-07-03 13:25:21.0 2019-07-03 13:25:21.142
          holyfoot Alexey Botchkov made changes -
          Fix Version/s 10.1.41 [ 23406 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.1 [ 16100 ]
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          holyfoot Alexey Botchkov made changes -
          GeoffMontee Geoff Montee (Inactive) made changes -
          Fix Version/s 10.2.26 [ 23409 ]
          Fix Version/s 10.3.17 [ 23411 ]
          Fix Version/s 10.4.7 [ 23720 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 97727 ] MariaDB v4 [ 156388 ]
          mariadb-jira-automation Jira Automation (IT) made changes -
          Zendesk Related Tickets 191771

          People

            holyfoot Alexey Botchkov
            GeoffMontee Geoff Montee (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.