[MDEV-19851] server_audit plugin should not allow server_audit_output_type=SYSLOG on Windows Created: 2019-06-24 Updated: 2019-07-06 Resolved: 2019-07-03 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Platform Windows, Plugin - Audit |
| Affects Version/s: | 10.2.25, 10.1.40, 10.3.16, 10.4.6 |
| Fix Version/s: | 10.2.26, 10.1.41, 10.3.17, 10.4.7 |
| Type: | Bug | Priority: | Major |
| Reporter: | Geoff Montee (Inactive) | Assignee: | Alexey Botchkov |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||
| Description |
|
Windows does not have syslog, so the server_audit plugin does not try to build syslog support on Windows. Instead, it just defines the syslog-related functions as noops on Windows: https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L25 server_audit_output_type=SYSLOG can still be set on Windows: https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L389 https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L2740 Since the syslog functions are defined as noops on Windows, this output type will not do anything. It seems like it would be better to not allow server_audit_output_type=SYSLOG on Windows. |
| Comments |
| Comment by Alexey Botchkov [ 2019-07-03 ] |
|
http://lists.askmonty.org/pipermail/commits/2019-July/013888.html |