Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19851

server_audit plugin should not allow server_audit_output_type=SYSLOG on Windows

    Details

      Description

      Windows does not have syslog, so the server_audit plugin does not try to build syslog support on Windows. Instead, it just defines the syslog-related functions as noops on Windows:

      https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L25

      server_audit_output_type=SYSLOG can still be set on Windows:

      https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L389

      https://github.com/MariaDB/server/blob/mariadb-10.4.6/plugin/server_audit/server_audit.c#L2740

      Since the syslog functions are defined as noops on Windows, this output type will not do anything.

      It seems like it would be better to not allow server_audit_output_type=SYSLOG on Windows.

        Attachments

          Activity

            People

            • Assignee:
              holyfoot Alexey Botchkov
              Reporter:
              GeoffMontee Geoff Montee
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: