Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19843

Modify ST_FIELD_INFO to use Type_handler and LEX_CSTRING

Details

    Description

      ST_FIELD_INFO has two problems:

      • It's not friently for user plugins, which may want to create INFORMATION_SCHEMA tables with their own data types.
      • When a Field is created inside Type_handler_xxx::make_schema_field(), strlen() is called for ST_FIELD_INFO::field_name, for every column, every time an INFORMATION_SCHEMA query is done. This is not performance wise.
      • In ST_FIELD_INFO, replace enum_field_types field_type to const Type_handler *handler.
      • In ST_FIELD_INFO, replace const char *field_name to LEX_CSTRING field_name.
        which will solve the two mentioned problems.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-19772 Add helper classes for ST_FIELD_INFO

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-19810 Reuse new I_S table definition helper classes for InnoDB

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-19818 Reuse new I_S table definition helper classes for TokuDB

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-19832 Reuse new I_S table definition helper classes for Spider

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-19833 Reuse new I_S table definition helper classes for Mronga

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-19836 Reuse new I_S table definition helper classes for RocksDB

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2019-06-24 02:29:44.0 2019-06-24 02:29:44.14
            bar Alexander Barkov made changes -
            Fix Version/s 10.5.0 [ 23709 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 97701 ] MariaDB v4 [ 134007 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.