Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19830

MyRocks build fails on ppc64le: cinttypes: No such file or directory

Details

    Description

      After the latest upstream merge, MyRocks build fails on ppc64:

      https://buildbot.askmonty.org/buildbot/builders/p8-suse12-rpm/builds/6933/steps/compile/logs/stdio

      https://buildbot.askmonty.org/buildbot/builders/kvm-deb-bionic-ppc64le/builds/2007/steps/compile/logs/stdio

      The error is:

      rocksdb/rocksdb/util/crc32c_ppc.c:9:21: fatal error: cinttypes: No such file or directory

      The file is crc32c_ppc .c, this explains why only PPC is affected.
      <cinttypes> is a C++ header, so C file should not be including it (thanks to svoj for pointing this out)

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-19935 Create unified CRC-32 interface

          • Major - Major loss of function.
          • Closed
          links to

          Web Link upstream fix

          Activity

            Ascending order - Click to sort in descending order
            psergei Sergei Petrunia added a comment -

            https://github.com/facebook/rocksdb/pull/5499

            psergei Sergei Petrunia added a comment - https://github.com/facebook/rocksdb/pull/5499
            marko Marko Mäkelä added a comment -

            Even better, the MyRocks compilation in MariaDB should not duplicate code that MariaDB already contains, in extra/crc32-vpmsum.

            marko Marko Mäkelä added a comment - Even better, the MyRocks compilation in MariaDB should not duplicate code that MariaDB already contains, in extra/crc32-vpmsum .
            danblack Daniel Black added a comment -

            Thanks psergey for assistance with upstream fix.

            danblack Daniel Black added a comment - Thanks psergey for assistance with upstream fix.
            psergei Sergei Petrunia added a comment -

            Testing the fix in the buildbot:
            https://github.com/mariadb/server/commits/bb-10.2-mdev19830

            psergei Sergei Petrunia added a comment - Testing the fix in the buildbot: https://github.com/mariadb/server/commits/bb-10.2-mdev19830
            psergei Sergei Petrunia added a comment -

            This was fixed by https://github.com/mariadb/server/commit/9abdf11ed1797cfd303170091869d0d89faae6f1

            psergei Sergei Petrunia added a comment - This was fixed by https://github.com/mariadb/server/commit/9abdf11ed1797cfd303170091869d0d89faae6f1

            People

              psergei Sergei Petrunia
              psergei Sergei Petrunia
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.