[MDEV-19830] MyRocks build fails on ppc64le: cinttypes: No such file or directory Created: 2019-06-21  Updated: 2019-07-26  Resolved: 2019-07-26

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - RocksDB
Affects Version/s: 10.2
Fix Version/s: 10.2.26, 10.3.17, 10.4.7

Type: Bug Priority: Major
Reporter: Sergei Petrunia Assignee: Sergei Petrunia
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-19935 Create unified CRC-32 interface Closed

 Description   

After the latest upstream merge, MyRocks build fails on ppc64:

https://buildbot.askmonty.org/buildbot/builders/p8-suse12-rpm/builds/6933/steps/compile/logs/stdio

https://buildbot.askmonty.org/buildbot/builders/kvm-deb-bionic-ppc64le/builds/2007/steps/compile/logs/stdio

The error is:

rocksdb/rocksdb/util/crc32c_ppc.c:9:21: fatal error: cinttypes: No such file or directory

The file is crc32c_ppc .c, this explains why only PPC is affected.
<cinttypes> is a C++ header, so C file should not be including it (thanks to svoj for pointing this out)



 Comments   
Comment by Sergei Petrunia [ 2019-06-22 ]

https://github.com/facebook/rocksdb/pull/5499

Comment by Marko Mäkelä [ 2019-07-03 ]

Even better, the MyRocks compilation in MariaDB should not duplicate code that MariaDB already contains, in extra/crc32-vpmsum.

Comment by Daniel Black [ 2019-07-05 ]

Thanks psergey for assistance with upstream fix.

Comment by Sergei Petrunia [ 2019-07-07 ]

Testing the fix in the buildbot:
https://github.com/mariadb/server/commits/bb-10.2-mdev19830

Comment by Sergei Petrunia [ 2019-07-26 ]

This was fixed by https://github.com/mariadb/server/commit/9abdf11ed1797cfd303170091869d0d89faae6f1

Generated at Thu Feb 08 08:54:41 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.